Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2066633002: Bind key for toggleBrailleCaptions (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bind key for toggleBrailleCaptions BUG=617668 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae57a55d4e10ca7d613cbdfceaf834b64dfe9c7d Cr-Commit-Position: refs/heads/master@{#399655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
David Tseng
4 years, 6 months ago (2016-06-13 21:09:38 UTC) #4
dmazzoni
lgtm
4 years, 6 months ago (2016-06-14 05:46:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066633002/1
4 years, 6 months ago (2016-06-14 05:46:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 06:34:17 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 06:34:23 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 06:36:04 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae57a55d4e10ca7d613cbdfceaf834b64dfe9c7d
Cr-Commit-Position: refs/heads/master@{#399655}

Powered by Google App Engine
This is Rietveld 408576698