Issue 206663003: Clip the start position when performing SVG text queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206663003: Clip the start position when performing SVG text queries (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
pdr., f(malita), Stephen Chennney, rwlbuis

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Clip the start position when performing SVG text queries If a text query straddles multiple line boxes, only the first would be considered, because |startPosition| would end up being negative. Instead clip the character range to [0) (the following functions will clip against the end position) and only reject ranges that are empty i.e. that appear before the current fragment (logically.) BUG=353462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169682

Patch Set 1 #

Patch Set 2 : Add missing -expected.txt. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
A	LayoutTests/svg/text/text-getSubStringLength.html	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/text/text-getSubStringLength-expected.txt	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextQuery.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/206663003/20001

6 years, 9 months ago (2014-03-20 19:23:26 UTC) #4

Message was sent while issue was closed.

Change committed as 169682

Expand Messages | Collapse Messages