Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2066603007: PPC: [Heap] Fix comparing against new space top pointer (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Heap] Fix comparing against new space top pointer Port d6473f5c14de5f52866b41730807932158fcaffb Original commit message: See bug description. R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:619382 LOG=N Committed: https://crrev.com/b95de0441228b874bd125e9afe18e08b5b02b918 Cr-Commit-Position: refs/heads/master@{#37023}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment, removed redundant load #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/ppc/macro-assembler-ppc.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-16 05:05:23 UTC) #1
john.yan
just one comment otherwise lgtm https://codereview.chromium.org/2066603007/diff/1/src/ppc/macro-assembler-ppc.cc File src/ppc/macro-assembler-ppc.cc (right): https://codereview.chromium.org/2066603007/diff/1/src/ppc/macro-assembler-ppc.cc#newcode4734 src/ppc/macro-assembler-ppc.cc:4734: mov(ip, Operand(new_space_allocation_top_adr)); I am ...
4 years, 6 months ago (2016-06-16 05:13:49 UTC) #2
JaideepBajwa
On 2016/06/16 05:13:49, john.yan wrote: > just one comment otherwise lgtm > > https://codereview.chromium.org/2066603007/diff/1/src/ppc/macro-assembler-ppc.cc > ...
4 years, 6 months ago (2016-06-16 05:26:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066603007/20001
4 years, 6 months ago (2016-06-16 06:00:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 06:25:44 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 06:26:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b95de0441228b874bd125e9afe18e08b5b02b918
Cr-Commit-Position: refs/heads/master@{#37023}

Powered by Google App Engine
This is Rietveld 408576698