Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2066603006: Enable RGB5_A1 format related webgl2 conformance tests. (Closed)

Created:
4 years, 6 months ago by Zhenyao Mo
Modified:
4 years, 6 months ago
Reviewers:
Jamie Madill
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable RGB5_A1 format related webgl2 conformance tests. BUG=616176 TEST=win8 gpu bot TBR=jmadill@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6b21579379491b38288d5772d210937b62f2332c Cr-Commit-Position: refs/heads/master@{#400061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -74 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066603006/1
4 years, 6 months ago (2016-06-16 00:31:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 00:36:48 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 00:37:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b21579379491b38288d5772d210937b62f2332c Cr-Commit-Position: refs/heads/master@{#400061}
4 years, 6 months ago (2016-06-16 00:38:12 UTC) #7
Jamie Madill
Mo, how come you didn't use the bots for this? The ANGLE fix isn't rolled ...
4 years, 6 months ago (2016-06-16 01:09:45 UTC) #8
Zhenyao Mo
On 2016/06/16 01:09:45, Jamie Madill wrote: > Mo, how come you didn't use the bots ...
4 years, 6 months ago (2016-06-16 02:52:38 UTC) #9
Jamie Madill
On 2016/06/16 02:52:38, Zhenyao Mo wrote: > On 2016/06/16 01:09:45, Jamie Madill wrote: > > ...
4 years, 6 months ago (2016-06-16 13:31:45 UTC) #10
Zhenyao Mo
4 years, 6 months ago (2016-06-16 16:06:54 UTC) #11
Message was sent while issue was closed.
On 2016/06/16 13:31:45, Jamie Madill wrote:
> On 2016/06/16 02:52:38, Zhenyao Mo wrote:
> > On 2016/06/16 01:09:45, Jamie Madill wrote:
> > > Mo, how come you didn't use the bots for this? The ANGLE fix isn't rolled
> into
> > > Chromium yet.
> > 
> > Aren't all win8 bots are on FYI and runing with ToT ANGLE? Besides, no win8
> try
> > bots, so no need to run any unrelated ones and waste energy.
> 
> Hm, you're right about Win8. Still I think for best policy it would be good to
> wait. If someone ran the tests locally on Win8 they'd get unexpected failures.

You are right.  I'll be more patient next time.

Powered by Google App Engine
This is Rietveld 408576698