Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: net/socket/ssl_client_socket_impl.cc

Issue 2066603004: Return enum from TransportSecurityState::CheckPublicKeyPins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add DCHECK() Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_impl.cc
diff --git a/net/socket/ssl_client_socket_impl.cc b/net/socket/ssl_client_socket_impl.cc
index bcd66037690e803e7ded9f276660fcd24d328cea..3d4bf147845cc553a7515575fb342bba2da251c2 100644
--- a/net/socket/ssl_client_socket_impl.cc
+++ b/net/socket/ssl_client_socket_impl.cc
@@ -1332,16 +1332,24 @@ int SSLClientSocketImpl::DoVerifyCertComplete(int result) {
const CertStatus cert_status = server_cert_verify_result_.cert_status;
if (transport_security_state_ &&
(result == OK ||
- (IsCertificateError(result) && IsCertStatusMinorError(cert_status))) &&
- !transport_security_state_->CheckPublicKeyPins(
- host_and_port_, server_cert_verify_result_.is_issued_by_known_root,
- server_cert_verify_result_.public_key_hashes, server_cert_.get(),
- server_cert_verify_result_.verified_cert.get(),
- TransportSecurityState::ENABLE_PIN_REPORTS, &pinning_failure_log_)) {
- if (server_cert_verify_result_.is_issued_by_known_root)
- result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
- else
- pkp_bypassed_ = true;
+ (IsCertificateError(result) && IsCertStatusMinorError(cert_status)))) {
+ TransportSecurityState::PKPStatus pin_validity =
+ transport_security_state_->CheckPublicKeyPins(
+ host_and_port_, server_cert_verify_result_.is_issued_by_known_root,
+ server_cert_verify_result_.public_key_hashes, server_cert_.get(),
+ server_cert_verify_result_.verified_cert.get(),
+ TransportSecurityState::ENABLE_PIN_REPORTS, &pinning_failure_log_);
+ switch (pin_validity) {
+ case TransportSecurityState::PKPStatus::VIOLATED:
+ result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
+ break;
+ case TransportSecurityState::PKPStatus::BYPASSED:
+ pkp_bypassed_ = true;
+ // Fall through.
+ case TransportSecurityState::PKPStatus::OK:
+ // Do nothing.
+ break;
+ }
}
if (result == OK) {

Powered by Google App Engine
This is Rietveld 408576698