Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

Issue 2066593003: Add a general purpose facility for letting background tasks wait until (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
index 6a83117efad3de290489f6103c5e971697e07d64..33037bfa6e6fe85d44c2a2e9da960d046c71b043 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
@@ -8,13 +8,16 @@ import android.content.Context;
import android.os.Bundle;
import org.chromium.base.Callback;
+import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
+import org.chromium.chrome.browser.ChromeBackgroundServiceWaiter;
import org.chromium.chrome.browser.offlinepages.interfaces.BackgroundSchedulerProcessor;
/**
* Handles servicing of background offlining requests coming via the GcmNetworkManager.
*/
public class BackgroundOfflinerTask {
+ private static final String TAG = "BGOfflinerTask";
public BackgroundOfflinerTask(BackgroundSchedulerProcessor bridge) {
mBridge = bridge;
@@ -31,7 +34,9 @@ public class BackgroundOfflinerTask {
*
* @returns true for success
*/
- public boolean startBackgroundRequests(Context context, Bundle bundle) {
+ public boolean startBackgroundRequests(Context context, Bundle bundle,
+ ChromeBackgroundServiceWaiter waiter) {
+ mWaiter = waiter;
processBackgroundRequests(bundle);
// Gather UMA data to measure how often the user's machine is amenable to background
@@ -64,11 +69,15 @@ public class BackgroundOfflinerTask {
*/
@Override
public void onResult(Boolean result) {
- // TODO(petewil): Release the wake lock.
+ // Release the wake lock.
+ Log.d(TAG, "onProcessingDone");
+ mWaiter.onWaitDone();
}
};
// Pass the activation on to the bridge to the C++ RequestCoordinator.
mBridge.startProcessing(callback);
}
+
+ private ChromeBackgroundServiceWaiter mWaiter;
dougarnett 2016/06/13 21:53:35 members before methods
Pete Williamson 2016/06/13 23:23:10 Done.
}

Powered by Google App Engine
This is Rietveld 408576698