Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: telemetry/telemetry/internal/actions/scroll.js

Issue 2066573004: Use CSS pixels for scrolling tests. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Use CSS pixels for scrolling tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/actions/scroll.js
diff --git a/telemetry/telemetry/internal/actions/scroll.js b/telemetry/telemetry/internal/actions/scroll.js
index 1a295d05fca083781984c7d27193d27d3a6bc368..d23cd63984dab41518992ece4a3ca5b7e0d68059 100644
--- a/telemetry/telemetry/internal/actions/scroll.js
+++ b/telemetry/telemetry/internal/actions/scroll.js
@@ -124,10 +124,14 @@
this.getScrollDistance_());
var rect = __GestureCommon_GetBoundingVisibleRect(this.options_.element_);
+ // TODO(bccheng): workaround crbug/599656
+ // Use device-independent pixel value for the x and y positions
var start_left =
- rect.left + rect.width * this.options_.left_start_ratio_;
+ rect.left + (rect.width / window.devicePixelRatio) *
+ this.options_.left_start_ratio_;
var start_top =
- rect.top + rect.height * this.options_.top_start_ratio_;
+ rect.top + (rect.height / window.devicePixelRatio) *
+ this.options_.top_start_ratio_;
chrome.gpuBenchmarking.smoothScrollBy(
distance, this.onGestureComplete_.bind(this), start_left, start_top,
this.options_.gesture_source_type_, this.options_.direction_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698