Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2066563002: Rename StyleLayoutData to StyleGeometryData (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StyleLayoutData to StyleGeometryData The term 'geometry' better matches what is stored here (and is also more in line with the SVG spec chapter [1] that defines most of the properties here.) Rename the SVGComputedStyle::layout field to 'geometry' to match. This is a mechanical rename-only CL, with the exception of some additional whitespace fixups. [1] https://svgwg.org/svg2-draft/geometry.html ("Geometry Properties") BUG=603956 Committed: https://crrev.com/7505794623b19588cd5a77236d4baa21e41c0864 Cr-Commit-Position: refs/heads/master@{#399649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -60 lines) Patch
M third_party/WebKit/Source/core/style/SVGComputedStyle.h View 3 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyleDefs.h View 1 chunk +23 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyleDefs.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
fs
4 years, 6 months ago (2016-06-13 18:07:01 UTC) #2
pdr.
lgtm
4 years, 6 months ago (2016-06-13 18:40:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066563002/1
4 years, 6 months ago (2016-06-13 18:41:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238320)
4 years, 6 months ago (2016-06-13 22:37:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066563002/1
4 years, 6 months ago (2016-06-13 22:59:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 03:29:14 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 03:29:16 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 03:40:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7505794623b19588cd5a77236d4baa21e41c0864
Cr-Commit-Position: refs/heads/master@{#399649}

Powered by Google App Engine
This is Rietveld 408576698