Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2066543002: Fix the Material Design infobar icons size (Closed)

Created:
4 years, 6 months ago by Patrick Monette
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Sebastien Gabriel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Material Design infobar icons size The MD icon guidelines specify a size of 16pts including the 1pixel padding. The previous size was incorrectly 18pts (16pts excluding padding). BUG=619155 Committed: https://crrev.com/bbba2db87c51f5ea5618ccc45b429d1b9a5ef7b5 Cr-Commit-Position: refs/heads/master@{#399540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/infobars/core/infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Patrick Monette
Hey Peter, This was figured out last Friday when talking to sgabriel@ PTAL.
4 years, 6 months ago (2016-06-13 14:59:20 UTC) #2
Evan Stade
On 2016/06/13 14:59:20, Patrick Monette wrote: > Hey Peter, > > This was figured out ...
4 years, 6 months ago (2016-06-13 15:25:13 UTC) #3
Peter Kasting
LGTM
4 years, 6 months ago (2016-06-13 19:57:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066543002/1
4 years, 6 months ago (2016-06-13 20:05:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 21:13:06 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:13:19 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:15:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbba2db87c51f5ea5618ccc45b429d1b9a5ef7b5
Cr-Commit-Position: refs/heads/master@{#399540}

Powered by Google App Engine
This is Rietveld 408576698