gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig

Committed: https://crrev.com/128c298a0f9cf518d341a785d25d2709bfe5ee6b
Cr-Commit-Position: refs/heads/master@{#399465}

[Nico, 2016-06-13 14:31:04]

thakis@chromium.org changed reviewers:
+ justincohen@chromium.org, rohitrao@chromium.org

[Nico, 2016-06-13 14:31:05]

justincohen: review
rohitrao: owners stamps where needed (mostly ios/* I think)

[justincohen, 2016-06-13 15:37:04]

ios changes LGTM

[Nico, 2016-06-13 15:37:54]

can you look at the non-ios bits too?

[justincohen, 2016-06-13 16:11:14]

Everything LGTM.  Thanks!

[Nico, 2016-06-13 16:13:23]

Description was changed from

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

BUG=608380
==========

to

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

BUG=608380
TBR=rohitrao,thestig
==========

[Nico, 2016-06-13 16:13:41]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2016-06-13 16:13:41]

tbr rohitrao for ios/*, thestig for breakpad/*

[Nico, 2016-06-13 16:14:27]

Description was changed from

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

BUG=608380
TBR=rohitrao,thestig
==========

to

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig
==========

[Nico, 2016-06-13 16:14:31]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-06-13 16:14:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066533002/1

[rohitrao (ping after 24h), 2016-06-13 16:16:50]

lgtm

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi#oldcode2017
build/common.gypi:2017: # Only enabled by default for ninja because it's buggy
in VS.
We no longer need this VS-specific fix?

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi#oldcode6344
build/common.gypi:6344: # TODO(justincohen): Ninja only supports simulator for
now.
Is this still a TODO that needs to be addressed?

[Nico, 2016-06-13 16:18:29]

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi#oldcode6344
build/common.gypi:6344: # TODO(justincohen): Ninja only supports simulator for
now.
On 2016/06/13 16:16:50, rohitrao wrote:
> Is this still a TODO that needs to be addressed?

Given that we ship device builds with ninja, I'm assuming this is done. Ninja
defaults to simulator builds for historical reasons; if you want to make it
default to device builds I think you can just change this line. I don't know
which is a better default.

[commit-bot: I haz the power, 2016-06-13 16:20:38]

Description was changed from

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig
==========

to

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig
==========

[commit-bot: I haz the power, 2016-06-13 16:20:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-13 16:20:47]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 16:21:40]

Description was changed from

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig
==========

to

==========
gyp: <(GENERATOR) is now always ninja, so simplify some conditionals.

No intended behavior change.

BUG=608380
TBR=rohitrao,thestig

Committed: https://crrev.com/128c298a0f9cf518d341a785d25d2709bfe5ee6b
Cr-Commit-Position: refs/heads/master@{#399465}
==========

[commit-bot: I haz the power, 2016-06-13 16:21:41]

Patchset 1 (id:??) landed as
https://crrev.com/128c298a0f9cf518d341a785d25d2709bfe5ee6b
Cr-Commit-Position: refs/heads/master@{#399465}

[sdefresne, 2016-06-13 16:30:06]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-06-13 16:30:07]

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi
File build/common.gypi (left):

https://codereview.chromium.org/2066533002/diff/1/build/common.gypi#oldcode6344
build/common.gypi:6344: # TODO(justincohen): Ninja only supports simulator for
now.
On 2016/06/13 16:18:28, Nico (traveling...slow) wrote:
> On 2016/06/13 16:16:50, rohitrao wrote:
> > Is this still a TODO that needs to be addressed?
> 
> Given that we ship device builds with ninja, I'm assuming this is done. Ninja
> defaults to simulator builds for historical reasons; if you want to make it
> default to device builds I think you can just change this line. I don't know
> which is a better default.

AFAIK, gyp ninja generator override this value and the default is unused.

[Lei Zhang, 2016-06-13 17:47:38]

stampy lgtm