Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: build/common.gypi

Issue 2066503004: Revert of Disable "taking address of packed member" clang warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3019 matching lines...) Expand 10 before | Expand all | Expand 10 after
3030 'defines': [ 3030 'defines': [
3031 'ADDRESS_SANITIZER', 3031 'ADDRESS_SANITIZER',
3032 'MEMORY_TOOL_REPLACES_ALLOCATOR', 3032 'MEMORY_TOOL_REPLACES_ALLOCATOR',
3033 'MEMORY_SANITIZER_INITIAL_SIZE', 3033 'MEMORY_SANITIZER_INITIAL_SIZE',
3034 ], 3034 ],
3035 }], 3035 }],
3036 ['enable_wexit_time_destructors==1 and OS!="win"', { 3036 ['enable_wexit_time_destructors==1 and OS!="win"', {
3037 # TODO: Enable on Windows too, http://crbug.com/404525 3037 # TODO: Enable on Windows too, http://crbug.com/404525
3038 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']}, 3038 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
3039 }], 3039 }],
3040 ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="2 70823-1"', {
3041 # TODO(eugenis): https://crbug.com/619640
3042 'variables': { 'clang_warning_flags': ['-Wno-address-of-packed-member']} ,
3043 }],
3044 ['chromium_code==0', { 3040 ['chromium_code==0', {
3045 'variables': { 3041 'variables': {
3046 'clang_warning_flags': [ 3042 'clang_warning_flags': [
3047 # Lots of third-party libraries have unused variables. Instead of 3043 # Lots of third-party libraries have unused variables. Instead of
3048 # suppressing them individually, we just blanket suppress them here. 3044 # suppressing them individually, we just blanket suppress them here.
3049 '-Wno-unused-variable', 3045 '-Wno-unused-variable',
3050 ], 3046 ],
3051 }, 3047 },
3052 'conditions': [ 3048 'conditions': [
3053 [ 'os_posix==1 and OS!="mac" and OS!="ios"', { 3049 [ 'os_posix==1 and OS!="mac" and OS!="ios"', {
(...skipping 3288 matching lines...) Expand 10 before | Expand all | Expand 10 after
6342 # settings in target dicts. SYMROOT is a special case, because many other 6338 # settings in target dicts. SYMROOT is a special case, because many other
6343 # Xcode variables depend on it, including variables such as 6339 # Xcode variables depend on it, including variables such as
6344 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6340 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6345 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6341 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6346 # files to appear (when present) in the UI as actual files and not red 6342 # files to appear (when present) in the UI as actual files and not red
6347 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6343 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6348 # and therefore SYMROOT, needs to be set at the project level. 6344 # and therefore SYMROOT, needs to be set at the project level.
6349 'SYMROOT': '<(DEPTH)/xcodebuild', 6345 'SYMROOT': '<(DEPTH)/xcodebuild',
6350 }, 6346 },
6351 } 6347 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698