Implement device::BatteryStatus support for UPower daemon 0.99.x

device/battery/battery_status_manager_linux-inl.h

Index: device/battery/battery_status_manager_linux-inl.h
diff --git a/device/battery/battery_status_manager_linux-inl.h b/device/battery/battery_status_manager_linux-inl.h
new file mode 100644
index 0000000000000000000000000000000000000000..df6df8a6888821051e888c52bdd0fc9a886ea55e
--- /dev/null
+++ b/device/battery/battery_status_manager_linux-inl.h
@@ -0,0 +1,28 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.

[Ken Rockot(use gerrit already), 2016/07/10 14:57:15]

I don't see a good reason to add this file. Please just declare the constants in
battery_status_manager_linux.h and define them in the cc.

[markuso, 2016/07/21 12:39:31]

This file was added to share the names between unittests and implementation in
battery_status_manager_linux.cc.
If I declare them in battery_status_manager_linux.h, then I need to declare them
as DEVICE_BATTERY_EXPORT - otherwise there are linker problems (if I recall
correctly on linking the unittests). Adding DEVICE_BATTERY_EXPORT for these
constants pollutes the symbol table unnecessarily.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_BATTERY_BATTERY_STATUS_MANAGER_LINUX_INL_H_
+#define DEVICE_BATTERY_BATTERY_STATUS_MANAGER_LINUX_INL_H_
+
+namespace device {
+const char kUPowerServiceName[] = "org.freedesktop.UPower";
+const char kUPowerMethodEnumerateDevices[] = "EnumerateDevices";
+const char kUPowerMethodGetDisplayDevice[] = "GetDisplayDevice";
+const char kUPowerPath[] = "/org/freedesktop/UPower";
+const char kUPowerPropertyDaemonVersion[] = "DaemonVersion";
+const char kUPowerSignalDeviceAdded[] = "DeviceAdded";
+const char kUPowerSignalDeviceChanged[] = "DeviceChanged";
+const char kUPowerSignalDeviceRemoved[] = "DeviceRemoved";
+
+const char kUPowerDeviceInterfaceName[] = "org.freedesktop.UPower.Device";
+const char kUPowerDevicePropertyIsPresent[] = "IsPresent";
+const char kUPowerDevicePropertyPercentage[] = "Percentage";
+const char kUPowerDevicePropertyState[] = "State";
+const char kUPowerDevicePropertyTimeToEmpty[] = "TimeToEmpty";
+const char kUPowerDevicePropertyTimeToFull[] = "TimeToFull";
+const char kUPowerDevicePropertyType[] = "Type";
+const char kUPowerDeviceSignalChanged[] = "Changed";
+}  // namespace device
+
+#endif  // DEVICE_BATTERY_BATTERY_STATUS_MANAGER_LINUX_INL_H_