Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2066493007: Updates PhysicalWebScanner to use the new CBManagerState enum. (Closed)

Created:
4 years, 6 months ago by rohitrao (ping after 24h)
Modified:
4 years, 6 months ago
Reviewers:
Olivier, justincohen
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates PhysicalWebScanner to use the new CBManagerState enum. BUG=619813, 619982 TEST=None Committed: https://crrev.com/46a5f7fe6df57d900d80d37fd975535cc5f1ff48 Cr-Commit-Position: refs/heads/master@{#399985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M ios/chrome/common/physical_web/physical_web_scanner.mm View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rohitrao (ping after 24h)
4 years, 6 months ago (2016-06-15 17:49:58 UTC) #2
justincohen
lgtm
4 years, 6 months ago (2016-06-15 17:59:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066493007/1
4 years, 6 months ago (2016-06-15 18:02:00 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 18:52:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066493007/1
4 years, 6 months ago (2016-06-15 19:08:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 19:12:47 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 19:13:04 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/46a5f7fe6df57d900d80d37fd975535cc5f1ff48 Cr-Commit-Position: refs/heads/master@{#399985}
4 years, 6 months ago (2016-06-15 19:14:45 UTC) #13
Olivier
4 years, 6 months ago (2016-06-16 14:42:04 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698