exo: Remove TextureLayer implementation of Surface.

exo: Remove TextureLayer implementation of Surface.

SurfaceLayer is always used instead.

BUG=610086
Committed: https://crrev.com/9041045566176078861bd666fc00ff3e3527de8e
Cr-Commit-Position: refs/heads/master@{#400032}

[jbauman, 2016-06-15 18:30:16]

jbauman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-06-15 19:05:09]

lgtm with nits

https://codereview.chromium.org/2066493004/diff/1/components/exo/display.cc
File components/exo/display.cc (right):

https://codereview.chromium.org/2066493004/diff/1/components/exo/display.cc#n...
components/exo/display.cc:36: }
nit: move this up to previous line to be consistent with dtor.

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc
File components/exo/surface.cc (left):

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc#o...
components/exo/surface.cc:624: // Update contents by producing a new texture
mailbox for the current buffer.
nit: this could was here to handle lost context situations and that's currently
missing for cc::surfaces. I don't think that should stop us from removing this
code but maybe we can add a TODO somewhere in this file that is about fixing
that.

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc
File components/exo/surface.cc (right):

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc#n...
components/exo/surface.cc:203: factory_owner_ = make_scoped_refptr(new
SurfaceFactoryOwner);
nit: move to initializer list

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc#n...
components/exo/surface.cc:436: CommitSurfaceContents();
nit: can we just move the implementation of this function here again?

https://codereview.chromium.org/2066493004/diff/1/components/exo/surface.cc#n...
components/exo/surface.cc:436: CommitSurfaceContents();
nit: can we just move the impl of CommitSurfaceContents back into this function
now?

[jbauman, 2016-06-15 22:34:02]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-06-15 22:34:03]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2066493004/#ps20001
(title: "add todo, format")

[commit-bot: I haz the power, 2016-06-15 22:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066493004/20001

[commit-bot: I haz the power, 2016-06-15 22:41:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-15 22:41:31]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 22:42:41]

Description was changed from

==========
exo: Remove TextureLayer implementation of Surface.

SurfaceLayer is always used instead.

BUG=610086
==========

to

==========
exo: Remove TextureLayer implementation of Surface.

SurfaceLayer is always used instead.

BUG=610086

Committed: https://crrev.com/9041045566176078861bd666fc00ff3e3527de8e
Cr-Commit-Position: refs/heads/master@{#400032}
==========

[commit-bot: I haz the power, 2016-06-15 22:42:42]

Patchset 2 (id:??) landed as
https://crrev.com/9041045566176078861bd666fc00ff3e3527de8e
Cr-Commit-Position: refs/heads/master@{#400032}