Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: components/browser_sync/browser/profile_sync_service_startup_unittest.cc

Issue 2066493003: Revert of Sync: Support multiple setup UIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service_startup_unittest.cc
diff --git a/components/browser_sync/browser/profile_sync_service_startup_unittest.cc b/components/browser_sync/browser/profile_sync_service_startup_unittest.cc
index be3c641e428bce08f97703e6082713ad71b92c4b..86a9ad3af51657469447eec159016de8463a29ed 100644
--- a/components/browser_sync/browser/profile_sync_service_startup_unittest.cc
+++ b/components/browser_sync/browser/profile_sync_service_startup_unittest.cc
@@ -199,7 +199,7 @@
EXPECT_CALL(*data_type_manager, Stop()).Times(1);
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber());
- auto sync_blocker = sync_service_->GetSetupInProgressHandle();
+ sync_service_->SetSetupInProgress(true);
// Simulate successful signin as test_user.
std::string account_id = SimulateTestUserSignin(sync_service_.get());
@@ -207,7 +207,7 @@
IssueTestTokens(account_id);
// Simulate the UI telling sync it has finished setting up.
- sync_blocker.reset();
+ sync_service_->SetSetupInProgress(false);
sync_service_->SetFirstSetupComplete();
EXPECT_TRUE(sync_service_->IsSyncActive());
}
@@ -232,14 +232,14 @@
pref_service()->GetBoolean(sync_driver::prefs::kSyncFirstSetupComplete));
// Then start things up.
- auto sync_blocker = sync_service_->GetSetupInProgressHandle();
+ sync_service_->SetSetupInProgress(true);
// Simulate successful signin as test_user.
std::string account_id = SimulateTestUserSignin(sync_service_.get());
profile_sync_service_bundle_.auth_service()->LoadCredentials(account_id);
- sync_blocker.reset();
+ sync_service_->SetSetupInProgress(false);
// ProfileSyncService should try to start by requesting access token.
// This request should fail as login token was not issued.
EXPECT_FALSE(sync_service_->IsSyncActive());
@@ -271,12 +271,12 @@
WillRepeatedly(Return(DataTypeManager::CONFIGURED));
EXPECT_CALL(*data_type_manager, Stop()).Times(1);
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber());
- auto sync_blocker = sync_service_->GetSetupInProgressHandle();
+ sync_service_->SetSetupInProgress(true);
// Simulate successful signin.
SimulateTestUserSignin(sync_service_.get());
- sync_blocker.reset();
+ sync_service_->SetSetupInProgress(false);
// Verify we successfully finish startup and configuration.
EXPECT_TRUE(sync_service_->IsSyncActive());
@@ -292,7 +292,7 @@
sync_service_->Initialize();
// Sync should not start because there are no tokens yet.
EXPECT_FALSE(sync_service_->IsSyncActive());
- sync_service_->SetFirstSetupComplete();
+ sync_service_->SetSetupInProgress(false);
// Sync should not start because there are still no tokens.
EXPECT_FALSE(sync_service_->IsSyncActive());
@@ -478,8 +478,8 @@
EXPECT_CALL(observer_, OnStateChanged()).Times(AnyNumber());
sync_service_->Initialize();
- auto sync_blocker = sync_service_->GetSetupInProgressHandle();
- IssueTestTokens(account_id);
- sync_blocker.reset();
- EXPECT_FALSE(sync_service_->IsSyncActive());
-}
+ sync_service_->SetSetupInProgress(true);
+ IssueTestTokens(account_id);
+ sync_service_->SetSetupInProgress(false);
+ EXPECT_FALSE(sync_service_->IsSyncActive());
+}

Powered by Google App Engine
This is Rietveld 408576698