DescriptionRevert of Sync: Support multiple setup UIs. (patchset #10 id:200001 of https://codereview.chromium.org/2044303004/ )
Reason for revert:
Breaks browser_tests at Win7 Tests (dbg)(1):
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/49639
SupervisedUserServiceTest.ClearOmitOnRegistration
[2608:2460:0613/165536:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
[4836:2060:0613/165537:FATAL:dependency_manager.cc(111)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again.
Original issue's description:
> Sync: Support multiple setup UIs.
>
> Replaces the SetSetupInProgress mechanism with a scoped
> GetSetupInProgressHandle mechanism. This has two advantages:
>
> 1. Allows for multiple simultaneously open Setup UIs.
> 2. Prevents a buggy UI from blocking Sync indefinitely by forgetting
> to SetSetupInProgress(false).
>
> BUG=563721
>
> Committed: https://crrev.com/12c4b7c0a33a0b4d4d2ea0746325e8a371272248
> Cr-Commit-Position: refs/heads/master@{#399581}
TBR=zea@chromium.org,maxbogue@chromium.org,thestig@chromium.org,tommycli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=563721
Committed: https://crrev.com/06bbee4ce66d8827fd9c6a35f404fd21376f75a7
Cr-Commit-Position: refs/heads/master@{#399670}
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|