Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2066493003: Revert of Sync: Support multiple setup UIs. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, msramek+watch_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, pam+watch_chromium.org, markusheintz_, stevenjb+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sync: Support multiple setup UIs. (patchset #10 id:200001 of https://codereview.chromium.org/2044303004/ ) Reason for revert: Breaks browser_tests at Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/49639 SupervisedUserServiceTest.ClearOmitOnRegistration [2608:2460:0613/165536:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [4836:2060:0613/165537:FATAL:dependency_manager.cc(111)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. Original issue's description: > Sync: Support multiple setup UIs. > > Replaces the SetSetupInProgress mechanism with a scoped > GetSetupInProgressHandle mechanism. This has two advantages: > > 1. Allows for multiple simultaneously open Setup UIs. > 2. Prevents a buggy UI from blocking Sync indefinitely by forgetting > to SetSetupInProgress(false). > > BUG=563721 > > Committed: https://crrev.com/12c4b7c0a33a0b4d4d2ea0746325e8a371272248 > Cr-Commit-Position: refs/heads/master@{#399581} TBR=zea@chromium.org,maxbogue@chromium.org,thestig@chromium.org,tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563721 Committed: https://crrev.com/06bbee4ce66d8827fd9c6a35f404fd21376f75a7 Cr-Commit-Position: refs/heads/master@{#399670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -184 lines) Patch
M chrome/browser/browsing_data/history_counter_browsertest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.h View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 4 chunks +7 lines, -17 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 2 chunks +9 lines, -28 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_mock.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_startup_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/fake_sync_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync_driver/fake_sync_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync_driver/sync_service.h View 4 chunks +8 lines, -23 lines 0 comments Download
M components/sync_driver/sync_service.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_chromium
Created Revert of Sync: Support multiple setup UIs.
4 years, 6 months ago (2016-06-14 08:32:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066493003/1
4 years, 6 months ago (2016-06-14 08:32:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 08:33:43 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 08:33:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 08:35:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06bbee4ce66d8827fd9c6a35f404fd21376f75a7
Cr-Commit-Position: refs/heads/master@{#399670}

Powered by Google App Engine
This is Rietveld 408576698