Phone and email selection UI for PaymentRequest

Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
Committed: https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6
Cr-Commit-Position: refs/heads/master@{#400603}

[please use gerrit instead, 2016-06-16 04:29:48]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-06-16 04:29:49]

dfalcantara@, ptal android.

This is functional, but I'd like to add some more tests. Also, the Blink part of
this patch comes from http://crrev.com/2038423002 , which will land soon. After
that lands, I can rebase and make this patch much smaller.

Follow up patches will add more sensible contact details editing. Currently you
have to edit the full profile 8-O

[gone, 2016-06-16 18:40:02]

l-g-t-m, pending rebasing

https://chromiumcodereview.appspot.com/2066483010/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://chromiumcodereview.appspot.com/2066483010/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:228:
* @param requestContact  Whether the UI should show the shipping address and
option selection.
Does this text need to be changed?

[please use gerrit instead, 2016-06-16 21:12:45]

Also added tests. No rebase yet.

https://chromiumcodereview.appspot.com/2066483010/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
(right):

https://chromiumcodereview.appspot.com/2066483010/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:228:
* @param requestContact  Whether the UI should show the shipping address and
option selection.
On 2016/06/16 18:40:01, dfalcantara wrote:
> Does this text need to be changed?

Good catch. Fixed.

[please use gerrit instead, 2016-06-16 22:12:05]

Description was changed from

==========
Adding support for phone and email.

This change adds support for two new PaymentOptions for payer’s email
and payer’s phone number[1].

[1] https://github.com/w3c/browser-payment-api/pull/174

Original Blink patch by Byoungkwon Ko <gogag2@@gmail.com>.

BUG=617195
==========

to

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes from Blink to the browser the request for these fields and
finally exposes the data user selected in the PaymentResponse.

BUG=617195
==========

[please use gerrit instead, 2016-06-16 22:14:47]

Description was changed from

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes from Blink to the browser the request for these fields and
finally exposes the data user selected in the PaymentResponse.

BUG=617195
==========

to

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

[please use gerrit instead, 2016-06-16 22:19:40]

Patchset #5 (id:80001) has been deleted

[please use gerrit instead, 2016-06-16 23:15:46]

Description was changed from

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

to

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

[please use gerrit instead, 2016-06-16 23:21:55]

rouslan@chromium.org changed reviewers:
+ haraken@chromium.org, mek@chromium.org, palmer@chromium.org

[please use gerrit instead, 2016-06-16 23:21:56]

(mek@ is ooo ? haraken@ : mek@), ptal PaymentRequest.cpp.
I'm passing request_payer_email/phone from Blink to the browser now.

dfalcantara@, ptal android.
I've rebased and added a junit test and an integration test.

palmer@, ptal payment_request.mojom.
I've added a way for Blink to request email/phone from the browser.

[haraken, 2016-06-16 23:58:28]

Source/modules/ LGTM

[Marijn Kruisselbrink, 2016-06-17 07:16:09]

lgtm

[gone, 2016-06-17 19:51:25]

lgtm

[palmer, 2016-06-17 22:28:40]

LGTM with optional nit.

https://codereview.chromium.org/2066483010/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2066483010/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:232:
if (requestShipping && profile.getCountryCode() != null
Nit: This conditional and the one on lines 227 – 228 are a bit hairy. Perhaps
abstract them out into a well-named utility method.

[please use gerrit instead, 2016-06-17 22:54:45]

Sending to cq.

https://codereview.chromium.org/2066483010/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2066483010/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:232:
if (requestShipping && profile.getCountryCode() != null
On 2016/06/17 22:28:40, palmer wrote:
> Nit: This conditional and the one on lines 227 – 228 are a bit hairy. Perhaps
> abstract them out into a well-named utility method.

Done.

[please use gerrit instead, 2016-06-17 22:59:10]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-17 22:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, palmer@chromium.org, mek@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2066483010/#ps120001
(title: "Utility functions")

[commit-bot: I haz the power, 2016-06-17 22:59:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066483010/120001

[commit-bot: I haz the power, 2016-06-17 23:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 23:49:23]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-06-18 02:12:03]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-18 02:12:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, palmer@chromium.org, mek@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2066483010/#ps140001
(title: "Rebase again")

[commit-bot: I haz the power, 2016-06-18 02:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066483010/140001

[commit-bot: I haz the power, 2016-06-18 03:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 03:21:51]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-06-18 22:40:21]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-18 22:40:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, palmer@chromium.org, mek@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2066483010/#ps180001
(title: "Fix integration test")

[commit-bot: I haz the power, 2016-06-18 22:40:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066483010/180001

[commit-bot: I haz the power, 2016-06-18 23:12:55]

Description was changed from

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

to

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

[commit-bot: I haz the power, 2016-06-18 23:12:56]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-06-18 23:14:34]

Description was changed from

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195
==========

to

==========
Phone and email selection UI for PaymentRequest

This patch adds the user interface for the user to select their
preferred contact phone number and email address. An addition, this
patch passes the request for these fields from Blink to the browser.

BUG=617195

Committed: https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6
Cr-Commit-Position: refs/heads/master@{#400603}
==========

[commit-bot: I haz the power, 2016-06-18 23:14:36]

Patchset 9 (id:??) landed as
https://crrev.com/cf584c715d7973f4c206bcacee348d64c0ea34e6
Cr-Commit-Position: refs/heads/master@{#400603}