Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2066483006: WebMediaPlayerMSTest Fix (Closed)

Created:
4 years, 6 months ago by qiangchen
Modified:
4 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebMediaPlayerMSTest Fix In ASAN build, the HiddenPlayerTests would fail, because some posted tasks get run after the player is destroyed. We fix that issue in this CL. BUG=619631 Committed: https://crrev.com/bc252541d581eeca9086fe4fb2265b229c20bdb0 Cr-Commit-Position: refs/heads/master@{#399771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
qiangchen
The ASAN test fix.
4 years, 6 months ago (2016-06-14 18:43:31 UTC) #4
DaleCurtis
lgtm
4 years, 6 months ago (2016-06-14 19:09:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066483006/1
4 years, 6 months ago (2016-06-14 20:09:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 20:14:24 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 20:14:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 20:16:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc252541d581eeca9086fe4fb2265b229c20bdb0
Cr-Commit-Position: refs/heads/master@{#399771}

Powered by Google App Engine
This is Rietveld 408576698