Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2066423002: Do not use ordered dictionaries (Closed)

Created:
4 years, 6 months ago by eostroukhov-old
Modified:
4 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use ordered dictionaries This makes generated code less "clean" but makes the script compatible with older Python versions. This matters to non-Blink clients of V8 inspector. BUG= Committed: https://crrev.com/c50b56b0e3924cd2ad7eb0ae8205cae810704ba6 Cr-Commit-Position: refs/heads/master@{#400117}

Patch Set 1 #

Patch Set 2 : Reduced the changeset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066423002/1
4 years, 6 months ago (2016-06-15 19:28:20 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-15 19:28:22 UTC) #4
eostroukhov-old
4 years, 6 months ago (2016-06-15 20:32:38 UTC) #6
eostroukhov-old
4 years, 6 months ago (2016-06-15 23:40:11 UTC) #8
pfeldman
lgtm
4 years, 6 months ago (2016-06-16 08:28:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066423002/20001
4 years, 6 months ago (2016-06-16 08:28:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 09:40:45 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 09:40:52 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 09:41:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c50b56b0e3924cd2ad7eb0ae8205cae810704ba6
Cr-Commit-Position: refs/heads/master@{#400117}

Powered by Google App Engine
This is Rietveld 408576698