Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 206633002: Fix an incorrect usage of reusable handles in Dart_Allocate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 34180)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -3117,10 +3117,7 @@
if (type_obj.IsNull()) {
RETURN_TYPE_ERROR(isolate, type, Type);
}
- REUSABLE_CLASS_HANDLESCOPE(isolate);
- Class& cls = isolate->ClassHandle();
- cls = type_obj.type_class();
-
+ const Class& cls = Class::Handle(isolate, type_obj.type_class());
if (!cls.is_fields_marked_nullable()) {
// Mark all fields as nullable.
Class& iterate_cls = Class::Handle(isolate, cls.raw());
@@ -3140,9 +3137,7 @@
}
}
- REUSABLE_ERROR_HANDLESCOPE(isolate);
- Error& error = isolate->ErrorHandle();
- error = cls.EnsureIsFinalized(isolate);
+ const Error& error = Error::Handle(isolate, cls.EnsureIsFinalized(isolate));
if (!error.IsNull()) {
// An error occurred, return error object.
return Api::NewHandle(isolate, error.raw());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698