Adjust BackgroundWith1PxBorder corner radius to scale properly.

Adjust BackgroundWith1PxBorder corner radius to scale properly.

The ".5" in the existing radius was intended to get to the middle of the stroke,
but that portion of the radius value was in px and not DIP, so scaling the whole
thing wasn't correct.  Instead, set the corner radius to the value of the "inner
radius", then add .5 after scaling.

This fixes a problem where, at larger scale factors, the focus ring's curvature
was slightly different than the edge's curvature.  It also very slightly changes
the appearance of the corner (no one would notice without zooming in).

BUG=612758
TEST=none

Committed: https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699
Cr-Commit-Position: refs/heads/master@{#400089}

[Peter Kasting, 2016-06-15 22:31:23]

pkasting@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-06-15 23:51:48]

lgtm

https://codereview.chromium.org/2066303003/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/background_with_1_px_border.cc
(right):

https://codereview.chromium.org/2066303003/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/background_with_1_px_border.cc:35:
SkFloatToScalar(kCornerRadius * scale) + 0.5f;
should the addition be inside the cast?

[Peter Kasting, 2016-06-16 04:35:21]

https://codereview.chromium.org/2066303003/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/background_with_1_px_border.cc
(right):

https://codereview.chromium.org/2066303003/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/background_with_1_px_border.cc:35:
SkFloatToScalar(kCornerRadius * scale) + 0.5f;
On 2016/06/15 23:51:47, Evan Stade wrote:
> should the addition be inside the cast?

Yes.  Good catch.

[Peter Kasting, 2016-06-16 04:35:26]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-06-16 04:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2066303003/#ps20001
(title: "Move add inside cast")

[commit-bot: I haz the power, 2016-06-16 04:35:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2066303003/20001

[commit-bot: I haz the power, 2016-06-16 05:29:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 05:29:38]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 05:31:02]

Description was changed from

==========
Adjust BackgroundWith1PxBorder corner radius to scale properly.

The ".5" in the existing radius was intended to get to the middle of the stroke,
but that portion of the radius value was in px and not DIP, so scaling the whole
thing wasn't correct.  Instead, set the corner radius to the value of the "inner
radius", then add .5 after scaling.

This fixes a problem where, at larger scale factors, the focus ring's curvature
was slightly different than the edge's curvature.  It also very slightly changes
the appearance of the corner (no one would notice without zooming in).

BUG=612758
TEST=none
==========

to

==========
Adjust BackgroundWith1PxBorder corner radius to scale properly.

The ".5" in the existing radius was intended to get to the middle of the stroke,
but that portion of the radius value was in px and not DIP, so scaling the whole
thing wasn't correct.  Instead, set the corner radius to the value of the "inner
radius", then add .5 after scaling.

This fixes a problem where, at larger scale factors, the focus ring's curvature
was slightly different than the edge's curvature.  It also very slightly changes
the appearance of the corner (no one would notice without zooming in).

BUG=612758
TEST=none

Committed: https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699
Cr-Commit-Position: refs/heads/master@{#400089}
==========

[commit-bot: I haz the power, 2016-06-16 05:31:03]

Patchset 2 (id:??) landed as
https://crrev.com/f38647f5f74e6b04d14cbd6473201b40ed855699
Cr-Commit-Position: refs/heads/master@{#400089}