third_party/WebKit/Source/platform/fonts/SegmentedFontData.h - Issue 2066253002: Fix Refcount in FontDataCache for objects from FontFallbackIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SegmentedFontData.h

Issue 2066253002: Fix Refcount in FontDataCache for objects from FontFallbackIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/GlyphPageTreeNodeTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/SegmentedFontData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/SegmentedFontData.h

diff --git a/third_party/WebKit/Source/platform/fonts/SegmentedFontData.h b/third_party/WebKit/Source/platform/fonts/SegmentedFontData.h

index 3e7cb7fb02c903ae510a8bde496c87a294839369..52bebcf9a8e59b9399f7a8a4a0b13b35008cf04a 100644

--- a/third_party/WebKit/Source/platform/fonts/SegmentedFontData.h

+++ b/third_party/WebKit/Source/platform/fonts/SegmentedFontData.h

@@ -39,9 +39,9 @@ public:

~SegmentedFontData() override;

- void appendFace(const FontDataForRangeSet& fontDataForRangeSet) { m_faces.append(fontDataForRangeSet); }

+ void appendFace(const PassRefPtr<FontDataForRangeSet> fontDataForRangeSet) { m_faces.append(fontDataForRangeSet); }

unsigned numFaces() const { return m_faces.size(); }

- const FontDataForRangeSet& faceAt(unsigned i) const { return m_faces[i]; }

+ const PassRefPtr<FontDataForRangeSet> faceAt(unsigned i) const { return m_faces[i]; }

bool containsCharacter(UChar32) const;

private:

@@ -55,7 +55,7 @@ private:

bool isSegmented() const override;

bool shouldSkipDrawing() const override;

- Vector<FontDataForRangeSet, 1> m_faces;

+ Vector<RefPtr<FontDataForRangeSet>, 1> m_faces;

};

DEFINE_FONT_DATA_TYPE_CASTS(SegmentedFontData, true);