third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h - Issue 2066253002: Fix Refcount in FontDataCache for objects from FontFallbackIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h

Issue 2066253002: Fix Refcount in FontDataCache for objects from FontFallbackIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.cpp ('k') | third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h

diff --git a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h

index a8e1060ce01970006cc949844dac1f5c7b667cfe..7f1a065bae1e4a2d868c359b1dc13d5d2a6f80ea 100644

--- a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h

+++ b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.h

@@ -40,12 +40,12 @@ public:

// Some system fallback APIs (Windows, Android) require a character, or a

// portion of the string to be passed. On Mac and Linux, we get a list of

// fonts without passing in characters.

- const FontDataForRangeSet next(const Vector<UChar32>& hintList);

+ const PassRefPtr<FontDataForRangeSet> next(const Vector<UChar32>& hintList);

private:

FontFallbackIterator(const FontDescription&, PassRefPtr<FontFallbackList>,

FontFallbackPriority);

- bool rangeSetContributesForHint(const Vector<UChar32> hintList, const FontDataForRangeSet&);

+ bool rangeSetContributesForHint(const Vector<UChar32> hintList, const FontDataForRangeSet*);

bool alreadyLoadingRangeForHintChar(UChar32 hintChar);

void willUseRange(const AtomicString& family, const FontDataForRangeSet&);

@@ -68,7 +68,7 @@ private:

FallbackStage m_fallbackStage;

HashSet<UChar32> m_previouslyAskedForHint;

- Vector<FontDataForRangeSet> m_trackedLoadingRangeSets;

+ Vector<RefPtr<FontDataForRangeSet>> m_trackedLoadingRangeSets;

FontFallbackPriority m_fontFallbackPriority;

};