Issue 206623006: Avoid duplicate hash lookups in CustomElementScheduler::ensureCallbackQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206623006: Avoid duplicate hash lookups in CustomElementScheduler::ensureCallbackQueue (Closed)

Created:
6 years, 9 months ago by esprehn

Modified:
6 years, 9 months ago

Reviewers:
dominicc (has gone to gerrit), adamk, dglazkov

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Avoid duplicate hash lookups in CustomElementScheduler::ensureCallbackQueue We can use add() to avoid doing two hash lookups in the common case where there's no callback queue yet (ex. setting a new attribute) and we can also return a reference. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169920

Patch Set 1 #

Patch Set 2 : fix #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -21 lines)			Patch
	M	Source/core/dom/custom/CustomElementScheduler.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Source/core/dom/custom/CustomElementScheduler.cpp	View	1	7 chunks	+18 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

On 2014/03/25 03:21:06, esprehn wrote: Neat, you are a C++ major leaguer. LGTM

6 years, 9 months ago (2014-03-25 07:25:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/206623006/20001

6 years, 9 months ago (2014-03-25 07:31:21 UTC) #4

Message was sent while issue was closed.

Change committed as 169920

Expand Messages | Collapse Messages