Issue 206623005: Revert of SkPaint: eliminate some dead bytes in 64-bit build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206623005: Revert of SkPaint: eliminate some dead bytes in 64-bit build. (Closed)

Created:
6 years, 9 months ago by mtklein

Modified:
6 years, 9 months ago

Reviewers:
mtklein_C, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of SkPaint: eliminate some dead bytes in 64-bit build. (https://codereview.chromium.org/203203003/) Reason for revert: Huh, some Android tests are still failing despite the fix. IntelRhB, Xoom... that's weird. Original issue's description: > SkPaint: eliminate some dead bytes in 64-bit build. > > + memcpy-based copy constructor was hiding this gap -> manual copy constructor. > + Split tests for finer-grained failures. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13856 > > Committed: http://code.google.com/p/skia/source/detail?r=13887 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13888

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -40 lines)			Patch
M	include/core/SkPaint.h	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1 chunk	+13 lines, -26 lines	0 comments	Download
M	tests/PaintTest.cpp	View	6 chunks	+22 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of SkPaint: eliminate some dead bytes in 64-bit build.

6 years, 9 months ago (2014-03-21 01:39:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/206623005/1

6 years, 9 months ago (2014-03-21 01:39:59 UTC) #2

Message was sent while issue was closed.

Change committed as 13888