Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: src/compiler/verifier.cc

Issue 2066223002: [turbofan] Introduce CheckHole and CheckHoleNaN operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Blacklist test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 6612a830d7eb0ef8e45ee5dc792269ad1d2fa2f4..716f88228426fbd19e8537446a615fd1548a5d78 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -766,16 +766,6 @@ void Verifier::Visitor::Check(Node* node) {
CheckValueInputIs(node, 0, Type::Number());
CheckUpperIs(node, Type::Unsigned32());
break;
- case IrOpcode::kNumberIsHoleNaN:
- // Number -> Boolean
- CheckValueInputIs(node, 0, Type::Number());
- CheckUpperIs(node, Type::Boolean());
- break;
- case IrOpcode::kNumberConvertHoleNaN:
- // Number -> Number \/ Undefined
- CheckValueInputIs(node, 0, Type::Number());
- CheckUpperIs(node, Type::NumberOrUndefined());
- break;
case IrOpcode::kPlainPrimitiveToNumber:
// Type is Number.
CheckUpperIs(node, Type::Number());
@@ -940,6 +930,15 @@ void Verifier::Visitor::Check(Node* node) {
case IrOpcode::kCheckedTaggedToFloat64:
break;
+ case IrOpcode::kCheckFloat64Hole:
+ CheckValueInputIs(node, 0, Type::Number());
+ CheckUpperIs(node, Type::Number());
+ break;
+ case IrOpcode::kCheckTaggedHole:
+ CheckValueInputIs(node, 0, Type::Any());
+ CheckUpperIs(node, Type::Any());
+ break;
+
case IrOpcode::kLoadField:
// Object -> fieldtype
// TODO(rossberg): activate once machine ops are typed.
« no previous file with comments | « src/compiler/typer.cc ('k') | src/types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698