Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2066213002: clang/win: Use /FIintrin.h instead of /FIIntrin.h (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Use /FIintrin.h instead of /FIIntrin.h Since Windows uses a case-insensitive file system, this doesn't matter much, but if we ever want to turn on -Wnonportable-system-include-path we'll need this. (clang's lib/Headers/Intrin.h was renamed to intrin.h to match the Microsoft header in clang r272701.) BUG=617318 Committed: https://crrev.com/4c33b455ce98383000f33e3519ab320d6b8629c0 Cr-Commit-Position: refs/heads/master@{#399912}

Patch Set 1 #

Patch Set 2 : while here, also add bug link to todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +3 lines, -2 lines 0 comments Download
M build/config/win/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
Since we don't use the warning yet (and it doesn't even exist in our pinned ...
4 years, 6 months ago (2016-06-15 09:46:34 UTC) #2
hans
lgtm
4 years, 6 months ago (2016-06-15 14:38:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066213002/20001
4 years, 6 months ago (2016-06-15 14:39:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 16:06:30 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 16:06:36 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:09:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c33b455ce98383000f33e3519ab320d6b8629c0
Cr-Commit-Position: refs/heads/master@{#399912}

Powered by Google App Engine
This is Rietveld 408576698