Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 206613005: Extract RuntimeEventRouter from extensions Runtime API (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extract RuntimeEventRouter from extensions Runtime API Another step toward moving the runtime API to src/extensions so it can be used by app_shell. BUG=354552 TEST=browser_tests ExtensionApi*:*Runtime* TBR=xiyuan@chromium.org for header file move touching chrome/browser/chromeos/app_mode Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259477

Patch Set 1 #

Patch Set 2 : fix cros, android (runtime-api) #

Patch Set 3 : remove from android whitelist (runtime-api) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -196 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.h View 4 chunks +4 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 14 chunks +31 lines, -155 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A extensions/browser/api/runtime/runtime_event_router.h View 1 chunk +59 lines, -0 lines 0 comments Download
A extensions/browser/api/runtime/runtime_event_router.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M extensions/browser/process_manager.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
James Cook
yoz, PTAL This is a mechanical extraction of this class with a little bit of ...
6 years, 9 months ago (2014-03-25 20:23:50 UTC) #1
Yoyo Zhou
LGTM I think you can also remove chrome/browser/extensions/api/runtime_api.cc from the Android reinclusion list in the ...
6 years, 9 months ago (2014-03-25 22:16:00 UTC) #2
James Cook
On 2014/03/25 22:16:00, Yoyo Zhou wrote: > LGTM > I think you can also remove ...
6 years, 9 months ago (2014-03-25 22:37:12 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-25 22:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/206613005/100001
6 years, 9 months ago (2014-03-25 22:38:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 00:06:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-26 00:06:39 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-26 00:13:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/206613005/100001
6 years, 9 months ago (2014-03-26 00:13:42 UTC) #9
commit-bot: I haz the power
Change committed as 259477
6 years, 9 months ago (2014-03-26 04:27:33 UTC) #10
James Cook
6 years, 9 months ago (2014-03-27 00:08:05 UTC) #11
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/213313007/ by jamescook@chromium.org.

The reason for reverting is: After talking to yoz@ and rockot@ I don't
think we want to extract the runtime implementation to src/extensions. It's got
too much Chrome-specific stuff, and for app_shell we really need app_runtime and
not runtime.
.

Powered by Google App Engine
This is Rietveld 408576698