Refactor fetching profile avatar icons and labels repeated md-settings & md-user-manager (C++)

chrome/browser/profiles/profile_avatar_icon_util.h

Index: chrome/browser/profiles/profile_avatar_icon_util.h
diff --git a/chrome/browser/profiles/profile_avatar_icon_util.h b/chrome/browser/profiles/profile_avatar_icon_util.h
index 8d7ed521b60af556c9d5d4960f0c6c22e24269a4..5f1707a5930afe350a2625775f7f684c7f3e56a0 100644
--- a/chrome/browser/profiles/profile_avatar_icon_util.h
+++ b/chrome/browser/profiles/profile_avatar_icon_util.h
@@ -7,12 +7,14 @@
 
 #include <stddef.h>
 
+#include <memory>
 #include <string>
 
 #include "third_party/skia/include/core/SkColor.h"
 
 namespace base {
 class FilePath;
+class ListValue;
 }
 
 namespace gfx {
@@ -107,6 +109,10 @@ bool IsDefaultAvatarIconUrl(const std::string& icon_url, size_t *icon_index);
 bool GetImageURLWithThumbnailSize(
     const GURL& old_url, int thumbnail_size, GURL* new_url);
 
+// Returns a list of dictionaries containing default profile avatar icons and
+// labels.

[Mike Lerman, 2016/06/20 00:42:54]

Please note how this list is ordered.
Also note - what label? I assume this is the Profile name for display? Can
probably just call this the Avatar name, and such call the method IconsAndNames.

[Moe, 2016/06/20 17:24:08]

a. I amended the comment to note what the labels are and how the list is
ordered.
b. These 'labels' more describe the avatars for a11y. I chose the word 'label'
to avoid confusion with the legacy avatar names (that we don't use anymore
afaik).
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=10895
Maybe 'title' would've been a better choice. let's keep using the word 'label'
here for consistency with the resource IDs?

[Mike Lerman, 2016/06/20 17:38:02]

Ah, those labels used to also be the default profile name, but that doesn't seem
to be the case anymore. Label is fine then :)

+std::unique_ptr<base::ListValue> GetDefaultProfileAvatarIconsAndLabels();
+
 }  // namespace profiles
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_AVATAR_ICON_UTIL_H_