Refactor fetching profile avatar icons and labels repeated md-settings & md-user-manager (C++)

chrome/browser/profiles/profile_avatar_icon_util.cc

Index: chrome/browser/profiles/profile_avatar_icon_util.cc
diff --git a/chrome/browser/profiles/profile_avatar_icon_util.cc b/chrome/browser/profiles/profile_avatar_icon_util.cc
index 2d82b35a684ce27f9220bf0795ba8455ffd41856..7257e5ed3a93839ed342b652d2a6bf03f64e447e 100644
--- a/chrome/browser/profiles/profile_avatar_icon_util.cc
+++ b/chrome/browser/profiles/profile_avatar_icon_util.cc
@@ -14,6 +14,7 @@
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
+#include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/grit/generated_resources.h"
@@ -23,6 +24,7 @@
 #include "third_party/skia/include/core/SkPath.h"
 #include "third_party/skia/include/core/SkScalar.h"
 #include "third_party/skia/include/core/SkXfermode.h"
+#include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/rect.h"
@@ -493,4 +495,23 @@ bool GetImageURLWithThumbnailSize(
   return true;
 }
 
+std::unique_ptr<base::ListValue> GetDefaultProfileAvatarIconsAndLabels() {
+  std::unique_ptr<base::ListValue> avatars(new base::ListValue());
+
+  size_t placeholder_avatar_index = profiles::GetPlaceholderAvatarIndex();

[Mike Lerman, 2016/06/20 00:42:53]

nit: const

[Moe, 2016/06/20 17:24:08]

Done.

+  for (size_t i = 0; i < profiles::GetDefaultAvatarIconCount() &&
+                     i != placeholder_avatar_index;

[Mike Lerman, 2016/06/20 00:42:53]

nit: ++i

[Moe, 2016/06/20 17:24:08]

Done.

+       i++) {
+    std::unique_ptr<base::DictionaryValue> avatar_info(
+        new base::DictionaryValue());
+    avatar_info->SetString("url", profiles::GetDefaultAvatarIconUrl(i));
+    avatar_info->SetString(
+        "label", l10n_util::GetStringUTF16(
+                     profiles::GetDefaultAvatarLabelResourceIDAtIndex(i)));
+
+    avatars->Append(std::move(avatar_info));
+  }
+  return avatars;
+}
+
 }  // namespace profiles