Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2066093003: Refactor fetching profile avatar icons and labels repeated md-settings & md-user-manager (C++) (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
Reviewers:
tommycli, Mike Lerman
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@avatar-selector-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor fetching profile avatar icons and labels repeated md-settings & md-user-manager (C++) Committed: https://crrev.com/b11ebce75c8d73b26948aa4e77b51b2dbfab1774 Cr-Commit-Position: refs/heads/master@{#401041}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Total comments: 7

Patch Set 3 : Addressed comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M chrome/browser/profiles/profile_avatar_icon_util.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 2 1 chunk +1 line, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (6 generated)
Moe
Hi Tommy, this is the second part of the refactor. Please take a look.
4 years, 6 months ago (2016-06-15 21:14:34 UTC) #2
tommycli
This is LGTM thanks!
4 years, 6 months ago (2016-06-15 21:19:35 UTC) #3
tommycli
I got overly excited. I do some some nits below, but it's still LGTM sans ...
4 years, 6 months ago (2016-06-15 21:22:44 UTC) #4
Moe
Thanks Tommy. Mike, Could you please review this CL? https://codereview.chromium.org/2066093003/diff/1/chrome/browser/profiles/profile_avatar_icon_util.cc File chrome/browser/profiles/profile_avatar_icon_util.cc (right): https://codereview.chromium.org/2066093003/diff/1/chrome/browser/profiles/profile_avatar_icon_util.cc#newcode500 chrome/browser/profiles/profile_avatar_icon_util.cc:500: ...
4 years, 6 months ago (2016-06-16 13:36:46 UTC) #7
Mike Lerman
Sorry for the slow response, was OOO. LGTM % comments https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.cc File chrome/browser/profiles/profile_avatar_icon_util.cc (right): https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.cc#newcode501 ...
4 years, 6 months ago (2016-06-20 00:42:54 UTC) #8
Moe
Thank you Mike! https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.cc File chrome/browser/profiles/profile_avatar_icon_util.cc (right): https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.cc#newcode501 chrome/browser/profiles/profile_avatar_icon_util.cc:501: size_t placeholder_avatar_index = profiles::GetPlaceholderAvatarIndex(); On 2016/06/20 ...
4 years, 6 months ago (2016-06-20 17:24:08 UTC) #9
Mike Lerman
sLGTM https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.h File chrome/browser/profiles/profile_avatar_icon_util.h (right): https://codereview.chromium.org/2066093003/diff/40001/chrome/browser/profiles/profile_avatar_icon_util.h#newcode113 chrome/browser/profiles/profile_avatar_icon_util.h:113: // labels. On 2016/06/20 17:24:08, Moe wrote: > ...
4 years, 6 months ago (2016-06-20 17:38:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066093003/70001
4 years, 6 months ago (2016-06-21 17:54:20 UTC) #13
Moe
On 2016/06/21 17:54:20, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-06-21 17:55:49 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:70001)
4 years, 6 months ago (2016-06-21 18:00:19 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:16:33 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b11ebce75c8d73b26948aa4e77b51b2dbfab1774
Cr-Commit-Position: refs/heads/master@{#401041}

Powered by Google App Engine
This is Rietveld 408576698