Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2066093002: Add options validation code in WaitSetDispatcher::WaitSetAddImpl(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add options validation code in WaitSetDispatcher::WaitSetAddImpl(). Note: ValidateWaitSetAddOptions() of course need not be exposed, but it doesn't hurt (and the functionality isn't really isn't private -- what options are valid is well-defined, etc.) and certainly makes testing easier. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/5ef396db4e150c83ce8ce272e66ae656f333f40a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M mojo/edk/system/wait_set_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-14 22:28:26 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-15 19:44:12 UTC) #2
vardhan
lgtm
4 years, 6 months ago (2016-06-15 21:04:48 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-15 21:20:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ef396db4e150c83ce8ce272e66ae656f333f40a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698