Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 2066083002: SafeBrowising: Read and write V4Store from/to disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores
Patch Set: Nit: Make store creation and use more consistent. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index d149a568babc1f41e6e39e78bbf1cc4e7055c688..39bcb413d2f3ac84fa885294f9f88f67894b5b1f 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -4,12 +4,21 @@
import("//third_party/protobuf/proto_library.gni")
-proto_library("proto") {
+proto_library("safebrowsing_proto") {
sources = [
"safebrowsing.proto",
]
}
+proto_library("v4_store_proto") {
+ sources = [
+ "v4_store.proto",
+ ]
+ deps = [
+ ":safebrowsing_proto",
+ ]
+}
+
# GYP version: components/safe_browsing_db.gypi:safe_browsing_metadata_proto
proto_library("metadata_proto") {
sources = [
@@ -23,7 +32,7 @@ group("safe_browsing_db_shared") {
":database_manager",
":hit_report",
":prefix_set",
- ":proto",
+ ":safebrowsing_proto",
":util",
]
}
@@ -164,7 +173,7 @@ source_set("v4_database") {
"v4_database.h",
]
public_deps = [
- ":proto",
+ ":safebrowsing_proto",
]
deps = [
":v4_protocol_manager_util",
@@ -180,7 +189,7 @@ source_set("v4_get_hash_protocol_manager") {
"v4_get_hash_protocol_manager.h",
]
public_deps = [
- ":proto",
+ ":safebrowsing_proto",
]
deps = [
":util",
@@ -199,7 +208,7 @@ source_set("v4_local_database_manager") {
deps = [
":database_manager",
":hit_report",
- ":proto",
+ ":safebrowsing_proto",
":v4_database",
":v4_protocol_manager_util",
":v4_update_protocol_manager",
@@ -216,7 +225,7 @@ source_set("v4_protocol_manager_util") {
"v4_protocol_manager_util.h",
]
deps = [
- ":proto",
+ ":safebrowsing_proto",
"//base",
"//net",
"//url:url",
@@ -229,7 +238,8 @@ source_set("v4_store") {
"v4_store.h",
]
public_deps = [
- ":proto",
+ ":safebrowsing_proto",
+ ":v4_store_proto",
]
deps = [
":v4_protocol_manager_util",
@@ -243,7 +253,7 @@ source_set("v4_update_protocol_manager") {
"v4_update_protocol_manager.h",
]
deps = [
- ":proto",
+ ":safebrowsing_proto",
":util",
":v4_protocol_manager_util",
"//base",
@@ -261,12 +271,13 @@ source_set("unit_tests") {
"v4_database_unittest.cc",
"v4_get_hash_protocol_manager_unittest.cc",
"v4_protocol_manager_util_unittest.cc",
+ "v4_store_unittest.cc",
"v4_update_protocol_manager_unittest.cc",
]
deps = [
":database_manager",
":prefix_set",
- ":proto",
+ ":safebrowsing_proto",
":test_database_manager",
":util",
":v4_database",
@@ -274,6 +285,7 @@ source_set("unit_tests") {
":v4_local_database_manager",
":v4_protocol_manager_util",
":v4_store",
+ ":v4_store_proto",
":v4_update_protocol_manager",
"//base",
"//content/test:test_support",

Powered by Google App Engine
This is Rietveld 408576698