Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2066083002: SafeBrowising: Read and write V4Store from/to disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores
Patch Set: Track writes to store via UMA. Create a temp file for writing. Remove some DVLOGs. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3f8c7a8b02fde1876bd6cb1621e7a4b23ffc06e5..61fd1b5b35eabb8e56314343fcdf41373ea16f3f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -46413,6 +46413,29 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SafeBrowsing.V4StoreReadResult"
+ enum="SafeBrowsingStoreReadResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the parsing results of reading the SafeBrowsing V4 store file from
+ disk. Recorded every time a store is read from disk.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4StoreVersionRead">
+ <owner>vakh@chromium.org</owner>
+ <summary>Version read from a store file.</summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4StoreWriteResult"
+ enum="SafeBrowsingStoreWriteResult">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the results of writing the SafeBrowsing V4 store file to disk.
+ Recorded every time a store is written to disk.
+ </summary>
+</histogram>
+
<histogram name="SafeBrowsing.V4UpdateHttpResponseOrErrorCode"
enum="CombinedHttpResponseAndNetErrorCode">
<owner>vakh@chromium.org</owner>
@@ -87087,6 +87110,25 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="4" label="NO_STATE_ERROR"/>
</enum>
+<enum name="SafeBrowsingStoreReadResult" type="int">
+ <int value="0" label="UNEXPECTED_READ_FAILURE"/>
+ <int value="1" label="READ_SUCCESS"/>
+ <int value="2" label="FILE_UNREADABLE_FAILURE"/>
+ <int value="3" label="FILE_EMPTY_FAILURE"/>
+ <int value="4" label="PROTO_PARSING_FAILURE"/>
+ <int value="5" label="UNEXPECTED_MAGIC_NUMBER_FAILURE"/>
+ <int value="6" label="FILE_VERSION_TOO_LOW_FAILURE"/>
+ <int value="7" label="HASH_PREFIX_INFO_MISSING_FAILURE"/>
+</enum>
+
+<enum name="SafeBrowsingStoreWriteResult" type="int">
+ <int value="0" label="UNEXPECTED_WRITE_FAILURE"/>
+ <int value="1" label="WRITE_SUCCESS"/>
+ <int value="2" label="INVALID_RESPONSE_TYPE_FAILURE"/>
+ <int value="3" label="UNEXPECTED_BYTES_WRITTEN_FAILURE"/>
+ <int value="4" label="UNABLE_TO_RENAME_FAILURE"/>
+</enum>
+
<enum name="SafeBrowsingV4OperationResult" type="int">
<int value="0" label="STATUS_200"/>
<int value="1" label="PARSE_ERROR (subset of STATUS_200)"/>

Powered by Google App Engine
This is Rietveld 408576698