Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2066083002: SafeBrowising: Read and write V4Store from/to disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores
Patch Set: Nit: better test names. Tests for WriteToDisk Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4c24fa18c8254bb92a0de5975bf1eba6e577ba8b..614211079b7ec4b7d3881ac3c2bab7f1f56118f3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -46236,6 +46236,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SafeBrowsing.V4StoreReadEvent"
+ enum="SafeBrowsingStoreReadFailureType">
+ <owner>vakh@chromium.org</owner>
+ <summary>
+ Track the parsing results of reading the SafeBrowsing V4 store file from
Nathan Parker 2016/06/16 00:07:51 Say when/where this is recorded. e.g. "Recorded ev
+ disk.
+ </summary>
+</histogram>
+
+<histogram name="SafeBrowsing.V4StoreVersionRead">
+ <owner>vakh@chromium.org</owner>
+ <summary>Version read from the store file.</summary>
Nathan Parker 2016/06/16 00:07:50 from a store file
+</histogram>
+
<histogram name="SafeBrowsing.V4UpdateHttpResponseOrErrorCode"
enum="CombinedHttpResponseAndNetErrorCode">
<owner>vakh@chromium.org</owner>
@@ -86700,6 +86714,17 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="4" label="NO_STATE_ERROR"/>
</enum>
+<enum name="SafeBrowsingStoreReadFailureType" type="int">
+ <int value="0" label="UNEXPECTED_FAILURE"/>
+ <int value="1" label="SUCCESS"/>
+ <int value="2" label="FILE_UNREADABLE_FAILURE"/>
+ <int value="3" label="FILE_EMPTY_FAILURE"/>
+ <int value="4" label="PROTO_PARSING_FAILURE"/>
+ <int value="5" label="UNEXPECTED_MAGIC_NUMBER_FAILURE"/>
+ <int value="6" label="FILE_VERSION_TOO_LOW_FAILURE"/>
+ <int value="7" label="HASH_PREFIX_INFO_MISSING_FAILURE"/>
+</enum>
+
<enum name="SafeBrowsingV4OperationResult" type="int">
<int value="0" label="STATUS_200"/>
<int value="1" label="PARSE_ERROR (subset of STATUS_200)"/>

Powered by Google App Engine
This is Rietveld 408576698