Chromium Code Reviews Chromium Code Reviews
Issue 2066083002:
SafeBrowising: Read and write V4Store from/to disk (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@01_UpdateDbAndStores| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index de2e830d0d32d3ad8703e96ec35ef9f3e3e14342..e837300cc084814e289f31047cc242c2b9d0aec0 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -46476,6 +46476,29 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SafeBrowsing.V4StoreReadResult" |
| + enum="SafeBrowsingStoreReadResult"> |
| + <owner>vakh@chromium.org</owner> |
| + <summary> |
| + Track the parsing results of reading the SafeBrowsing V4 store file from |
| + disk. Recorded every time a store is read from disk. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="SafeBrowsing.V4StoreVersionRead"> |
|
rkaplow
2016/06/27 17:48:51
unit?
vakh (use Gerrit instead)
2016/06/27 19:51:28
This is just a number, it doesn't have any units.
|
| + <owner>vakh@chromium.org</owner> |
| + <summary>Version read from a store file.</summary> |
|
rkaplow
2016/06/27 17:48:51
also this seems a bit overly terse, not sure what
vakh (use Gerrit instead)
2016/06/27 19:51:28
Done.
|
| +</histogram> |
| + |
| +<histogram name="SafeBrowsing.V4StoreWriteResult" |
| + enum="SafeBrowsingStoreWriteResult"> |
| + <owner>vakh@chromium.org</owner> |
| + <summary> |
| + Track the results of writing the SafeBrowsing V4 store file to disk. |
| + Recorded every time a store is written to disk. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="SafeBrowsing.V4UpdateHttpResponseOrErrorCode" |
| enum="CombinedHttpResponseAndNetErrorCode"> |
| <owner>vakh@chromium.org</owner> |
| @@ -87164,6 +87187,25 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="4" label="NO_STATE_ERROR"/> |
| </enum> |
| +<enum name="SafeBrowsingStoreReadResult" type="int"> |
| + <int value="0" label="READ_SUCCESS"/> |
| + <int value="1" label="UNEXPECTED_READ_FAILURE"/> |
| + <int value="2" label="FILE_UNREADABLE_FAILURE"/> |
| + <int value="3" label="FILE_EMPTY_FAILURE"/> |
| + <int value="4" label="PROTO_PARSING_FAILURE"/> |
| + <int value="5" label="UNEXPECTED_MAGIC_NUMBER_FAILURE"/> |
| + <int value="6" label="FILE_VERSION_TOO_LOW_FAILURE"/> |
| + <int value="7" label="HASH_PREFIX_INFO_MISSING_FAILURE"/> |
| +</enum> |
| + |
| +<enum name="SafeBrowsingStoreWriteResult" type="int"> |
| + <int value="0" label="WRITE_SUCCESS"/> |
| + <int value="1" label="UNEXPECTED_WRITE_FAILURE"/> |
| + <int value="2" label="INVALID_RESPONSE_TYPE_FAILURE"/> |
| + <int value="3" label="UNEXPECTED_BYTES_WRITTEN_FAILURE"/> |
| + <int value="4" label="UNABLE_TO_RENAME_FAILURE"/> |
| +</enum> |
| + |
| <enum name="SafeBrowsingV4OperationResult" type="int"> |
| <int value="0" label="STATUS_200"/> |
| <int value="1" label="PARSE_ERROR (subset of STATUS_200)"/> |
