Chromium Code Reviews| Index: Source/core/dom/Document.cpp |
| diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp |
| index b35ac06b6f3bcc4d2f9532bc3dc037550b3bc1fe..b35c7efeb6a67b4040653ee55e18ee6059d51fac 100644 |
| --- a/Source/core/dom/Document.cpp |
| +++ b/Source/core/dom/Document.cpp |
| @@ -71,6 +71,7 @@ |
| #include "core/dom/Element.h" |
| #include "core/dom/ElementDataCache.h" |
| #include "core/dom/ElementTraversal.h" |
| +#include "core/dom/EventHandlerRegistry.h" |
| #include "core/dom/ExceptionCode.h" |
| #include "core/dom/ExecutionContextTask.h" |
| #include "core/dom/MainThreadTaskRunner.h" |
| @@ -2092,12 +2093,14 @@ void Document::attach(const AttachContext& context) |
| textAutosizer->updatePageInfo(); |
| m_lifecycle.advanceTo(DocumentLifecycle::StyleClean); |
| + lifecycleNotifier().notifyDocumentWasAttached(); |
| } |
| void Document::detach(const AttachContext& context) |
| { |
| ASSERT(isActive()); |
| m_lifecycle.advanceTo(DocumentLifecycle::Stopping); |
| + lifecycleNotifier().notifyWillDetachDocument(); |
|
abarth-chromium
2014/04/10 21:25:58
Typically folks who want this notification impleme
Sami
2014/04/11 16:46:53
Thanks for the hint. That looks perfect.
|
| if (page()) |
| page()->documentDetached(this); |
| @@ -2151,9 +2154,6 @@ void Document::detach(const AttachContext& context) |
| if (renderView) |
| renderView->destroy(); |
| - if (Document* parentDoc = parentDocument()) |
| - parentDoc->didClearTouchEventHandlers(this); |
| - |
| // This is required, as our LocalFrame might delete itself as soon as it detaches |
| // us. However, this violates Node::detach() semantics, as it's never |
| // possible to re-attach. Eventually Document::detach() should be renamed, |
| @@ -5024,80 +5024,6 @@ PassRefPtrWillBeRawPtr<TouchList> Document::createTouchList(WillBeHeapVector<Ref |
| return TouchList::create(touches); |
| } |
| -void Document::didAddTouchEventHandler(Node* handler) |
| -{ |
| - // The node should either be in this document, or be the Document node of a child |
| - // of this document. |
| - ASSERT(&handler->document() == this |
| - || (handler->isDocumentNode() && toDocument(handler)->parentDocument() == this)); |
| - if (!m_touchEventTargets.get()) |
| - m_touchEventTargets = adoptPtr(new TouchEventTargetSet); |
| - bool isFirstHandler = m_touchEventTargets->isEmpty(); |
| - |
| - if (!m_touchEventTargets->add(handler).isNewEntry) { |
| - // Just incremented refcount, no real change. |
| - // If this is a child document node, then the count should never go above 1. |
| - ASSERT(!handler->isDocumentNode() || &handler->document() == this); |
| - return; |
| - } |
| - |
| - if (isFirstHandler) { |
| - if (Document* parent = parentDocument()) { |
| - parent->didAddTouchEventHandler(this); |
| - } else { |
| - // This is the first touch handler on the whole page. |
| - if (FrameHost* frameHost = this->frameHost()) |
| - frameHost->chrome().client().needTouchEvents(true); |
| - } |
| - } |
| - |
| - // When we're all done with all frames, ensure touch hit rects are marked as dirty. |
| - if (!handler->isDocumentNode() || handler == this) { |
| - if (Page* page = this->page()) { |
| - if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) |
| - scrollingCoordinator->touchEventTargetRectsDidChange(); |
| - } |
| - } |
| -} |
| - |
| -void Document::didRemoveTouchEventHandler(Node* handler, bool clearAll) |
| -{ |
| - // Note that we can't assert that |handler| is in this document because it might be in |
| - // the process of moving out of it. |
| - ASSERT(clearAll || m_touchEventTargets->contains(handler)); |
| - if (!m_touchEventTargets.get()) |
| - return; |
| - |
| - if (clearAll) { |
| - if (!m_touchEventTargets->contains(handler)) |
| - return; |
| - m_touchEventTargets->removeAll(handler); |
| - } else { |
| - if (!m_touchEventTargets->remove(handler)) |
| - // Just decremented refcount, no real update. |
| - return; |
| - } |
| - |
| - if (m_touchEventTargets->isEmpty()) { |
| - if (Document* parent = parentDocument()) { |
| - // This was the last handler in this document, update the parent document too. |
| - parent->didRemoveTouchEventHandler(this, clearAll); |
| - } else { |
| - // We just removed the last touch handler on the whole page. |
| - if (FrameHost* frameHost = this->frameHost()) |
| - frameHost->chrome().client().needTouchEvents(false); |
| - } |
| - } |
| - |
| - // When we're all done with all frames, ensure touch hit rects are marked as dirty. |
| - if (!handler->isDocumentNode() || handler == this) { |
| - if (Page* page = this->page()) { |
| - if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) |
| - scrollingCoordinator->touchEventTargetRectsDidChange(); |
| - } |
| - } |
| -} |
| - |
| DocumentLoader* Document::loader() const |
| { |
| if (!m_frame) |