Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2066004: Mac: app mode loader (shim). (Closed)

Created:
10 years, 7 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org
Visibility:
Public.

Description

Mac: app mode loader (shim). Define an interface using which Chrome can be loaded from a minimal loader. Produce a binary for this loader (which can be put into a bundle). BUG=13148 TEST=not yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47576

Patch Set 1 #

Patch Set 2 : space fix #

Patch Set 3 : comments #

Total comments: 34

Patch Set 4 : stuff per mark #

Total comments: 14

Patch Set 5 : more changes per mark + merged ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -2 lines) Patch
A chrome/app/app_mode-Info.plist View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/app/app_mode_loader_mac.mm View 1 2 3 4 1 chunk +145 lines, -0 lines 0 comments Download
A chrome/app/chrome_dll_app_mode_mac.mm View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/app/framework.order View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/app_mode_common_mac.h View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/common/app_mode_common_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths_internal.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
Still a work in progress (obviously), but let's start getting some code in....
10 years, 7 months ago (2010-05-14 18:56:28 UTC) #1
Mark Mentovai
I’ll likely have more comments when I take a closer look, but it’s nice to ...
10 years, 7 months ago (2010-05-14 20:18:21 UTC) #2
viettrungluu
http://codereview.chromium.org/2066004/diff/4001/5001 File chrome/app/app_mode-Info.plist (right): http://codereview.chromium.org/2066004/diff/4001/5001#newcode14 chrome/app/app_mode-Info.plist:14: <string>APP_MODE_BUNDLE_ID</string> On 2010/05/14 20:18:21, Mark Mentovai wrote: > Bundle ...
10 years, 7 months ago (2010-05-15 04:06:56 UTC) #3
Mark Mentovai
lg with these changes http://codereview.chromium.org/2066004/diff/9001/8003 File chrome/app/app_mode_loader_mac.mm (right): http://codereview.chromium.org/2066004/diff/9001/8003#newcode5 chrome/app/app_mode_loader_mac.mm:5: // On Mac, one can't ...
10 years, 7 months ago (2010-05-17 21:56:17 UTC) #4
Mark Mentovai
10 years, 7 months ago (2010-05-17 22:02:42 UTC) #5
http://codereview.chromium.org/2066004/diff/9001/8003
File chrome/app/app_mode_loader_mac.mm (right):

http://codereview.chromium.org/2066004/diff/9001/8003#newcode16
chrome/app/app_mode_loader_mac.mm:16: #include <Cocoa/Cocoa.h>
#import <Foundation/Foundation.h>

http://codereview.chromium.org/2066004/diff/9001/8003#newcode129
chrome/app/app_mode_loader_mac.mm:129: CHECK_MSG(cr_dylib, "couldn't load
browser framework");
and "browser" is sort of a misnomer.

Powered by Google App Engine
This is Rietveld 408576698