Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2066003002: git_cl: convert to print_function (Closed)

Created:
4 years, 6 months ago by vapier
Modified:
4 years, 6 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git_cl: convert to print_function This makes the code work both in python2 and python3. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/a7fbd5a92a7b2687d599a118d3fc68d9a65b0fb6

Patch Set 1 #

Patch Set 2 : fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -183 lines) Patch
M git_cl.py View 1 58 chunks +177 lines, -183 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vapier
4 years, 6 months ago (2016-06-14 15:58:36 UTC) #2
tandrii(chromium)
LGTM
4 years, 6 months ago (2016-06-14 16:11:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066003002/1
4 years, 6 months ago (2016-06-16 15:38:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/626)
4 years, 6 months ago (2016-06-16 15:44:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2066003002/20001
4 years, 6 months ago (2016-06-16 16:14:34 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:17:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a7fbd5a92a7b26...

Powered by Google App Engine
This is Rietveld 408576698