Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2065983003:
Permissions bubble is no longer anchored to the fullscreen bubble. (Closed)
|
Created:
4 years, 6 months ago by Matt Giuca Modified:
4 years, 5 months ago CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, Elly Fong-Jones, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPermissions bubble is no longer anchored to the fullscreen bubble.
This fixes a bug where if the fullscreen bubble is deleted while the
permissions bubble is open, the permissions bubble will no longer be
anchored anywhere. Simplest fix was to decouple these two bubbles (so
the fullscreen bubble can now display over the top of the permissions
bubble for a few seconds).
BUG=619894
Committed: https://crrev.com/63388490f5cba741db9b49c1e04124c79ed3d1cd
Cr-Commit-Position: refs/heads/master@{#402133}
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
mgiuca@chromium.org changed reviewers: + raymes@google.com
I also asked ainslie@ what he thinks of the slight UI change on the bug. See discussion and screenshot there.
Description was changed from ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 ========== to ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 ==========
mgiuca@chromium.org changed reviewers: + raymes@chromium.org - raymes@google.com
Fixed email address.
raymes@chromium.org changed reviewers: + benwells@chromium.org, felt@chromium.org
Seems good :) but I don't really know this code and I'm not an owner. I think benwells was looking more at permission bubble stuff, so +benwells but it also seems like he's not an owner of this, so +felt too.
On 2016/06/15 09:14:29, raymes wrote: > Seems good :) but I don't really know this code and I'm not an owner. I think > benwells was looking more at permission bubble stuff, so +benwells but it also > seems like he's not an owner of this, so +felt too. Code is fine, but I'd like to see someone from UX say something about this. I'll add rolfe@ as well to the issue.
On 2016/06/15 17:03:50, benwells wrote: > On 2016/06/15 09:14:29, raymes wrote: > > Seems good :) but I don't really know this code and I'm not an owner. I think > > benwells was looking more at permission bubble stuff, so +benwells but it also > > seems like he's not an owner of this, so +felt too. > > Code is fine, but I'd like to see someone from UX say something about this. I'll > add rolfe@ as well to the issue. rolfe seems tentatively fine with this (she'd like a better solution but says to go ahead with this). Can we land it?
lgtm
The CQ bit was checked by mgiuca@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 ========== to ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 ========== to ========== Permissions bubble is no longer anchored to the fullscreen bubble. This fixes a bug where if the fullscreen bubble is deleted while the permissions bubble is open, the permissions bubble will no longer be anchored anywhere. Simplest fix was to decouple these two bubbles (so the fullscreen bubble can now display over the top of the permissions bubble for a few seconds). BUG=619894 Committed: https://crrev.com/63388490f5cba741db9b49c1e04124c79ed3d1cd Cr-Commit-Position: refs/heads/master@{#402133} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63388490f5cba741db9b49c1e04124c79ed3d1cd Cr-Commit-Position: refs/heads/master@{#402133}
Message was sent while issue was closed.
sorry for lack of review on this, I was OOO last week. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
