Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2065963002:
Turn on --ignition-generators by default. (Closed)
DescriptionTurn on --ignition-generators by default.
This CL merely sets the --ignition-generators flag to true. This flag is
currently only meaningful in combination with --ignition.
BUG=
Committed: https://crrev.com/dacc5a73cd1fb5334480850cd25b9729ef7c20cb
Cr-Commit-Position: refs/heads/master@{#37144}
Patch Set 1 #Patch Set 2 : generators-mirror #Patch Set 3 : again #Patch Set 4 : depend on ignition change #Patch Set 5 : depend on another CL and enable tests again #
Depends on Patchset: Messages
Total messages: 29 (15 generated)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065963002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065963002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065963002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7303) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065963002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Turn on --ignition-generators by default. BUG= ========== to ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ==========
neis@chromium.org changed reviewers: + mstarzinger@chromium.org, rmcilroy@chromium.org
Description was changed from ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ========== to ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ==========
PTAL
LGTM. Nice!
LGTM, thanks.
The CQ bit was checked by neis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2065963002/#ps80001 (title: "depend on another CL and enable tests again")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065963002/80001
Message was sent while issue was closed.
Description was changed from ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ========== to ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= ========== to ========== Turn on --ignition-generators by default. This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= Committed: https://crrev.com/dacc5a73cd1fb5334480850cd25b9729ef7c20cb Cr-Commit-Position: refs/heads/master@{#37144} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/dacc5a73cd1fb5334480850cd25b9729ef7c20cb Cr-Commit-Position: refs/heads/master@{#37144} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
