Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3301)

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm

Issue 2065943002: Abstract notification clicks in its own dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..0d4a78dc01c205504e96cbdf782fefdb6fb64cdf
--- /dev/null
+++ b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
@@ -0,0 +1,175 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <AppKit/AppKit.h>
+
+#include "base/mac/scoped_nsobject.h"
+#include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
+#include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"
+#include "chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(NotificationResponseBuilderMacTest, TestNotificationClick) {
+ base::scoped_nsobject<NotificationBuilder> builder(
+ [[NotificationBuilder alloc] init]);
+ [builder setTitle:@"Title"];
+ [builder setSubTitle:@"https://www.miguel.com"];
+ [builder setContextMessage:@""];
+ [builder setTag:@"tag1"];
+ [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
+ [builder setNotificationId:@"notificationId"];
+ [builder setProfileId:@"profileId"];
+ [builder setIncognito:false];
+
+ NSUserNotification* notification = [builder buildUserNotification];
+ NSDictionary* response =
+ [NotificationResponseBuilder buildDictionary:notification];
+
+ NSNumber* operation =
+ [response objectForKey:notification_constants::kNotificationOperation];
+ NSNumber* buttonIndex =
+ [response objectForKey:notification_constants::kNotificationButtonIndex];
+ EXPECT_EQ(0 /* NOTIFICATION_CLICK */, operation.intValue);
+ EXPECT_EQ(-1, buttonIndex.intValue);
+}
+
+TEST(NotificationResponseBuilderMacTest, TestNotificationSettingsClick) {
+ base::scoped_nsobject<NotificationBuilder> builder(
+ [[NotificationBuilder alloc] init]);
+ [builder setTitle:@"Title"];
+ [builder setSubTitle:@"https://www.miguel.com"];
+ [builder setContextMessage:@""];
+ [builder setTag:@"tag1"];
+ [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
+ [builder setNotificationId:@"notificationId"];
+ [builder setProfileId:@"profileId"];
+ [builder setIncognito:false];
+
+ NSUserNotification* notification = [builder buildUserNotification];
+
+ // This will be set by the notification center to indicate the only available
+ // button was clicked.
+ [notification
+ setValue:
+ [NSNumber
+ numberWithInt:NSUserNotificationActivationTypeActionButtonClicked]
+ forKey:@"_activationType"];
+ NSDictionary* response =
+ [NotificationResponseBuilder buildDictionary:notification];
+
+ NSNumber* operation =
+ [response objectForKey:notification_constants::kNotificationOperation];
+ NSNumber* buttonIndex =
+ [response objectForKey:notification_constants::kNotificationButtonIndex];
+ EXPECT_EQ(2 /* NOTIFICATION_SETTINGS */, operation.intValue);
+ EXPECT_EQ(-1, buttonIndex.intValue);
+}
+
+TEST(NotificationResponseBuilderMacTest, TestNotificationOneActionClick) {
+ base::scoped_nsobject<NotificationBuilder> builder(
+ [[NotificationBuilder alloc] init]);
+ [builder setTitle:@"Title"];
+ [builder setSubTitle:@"https://www.miguel.com"];
+ [builder setContextMessage:@""];
+ [builder setButtons:@"Button1" secondaryButton:@""];
+ [builder setTag:@"tag1"];
+ [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
+ [builder setNotificationId:@"notificationId"];
+ [builder setProfileId:@"profileId"];
+ [builder setIncognito:false];
+
+ NSUserNotification* notification = [builder buildUserNotification];
+
+ // These values will be set by the notification center to indicate that button
+ // 1 was clicked.
+ [notification
+ setValue:
+ [NSNumber
+ numberWithInt:NSUserNotificationActivationTypeActionButtonClicked]
+ forKey:@"_activationType"];
+ [notification setValue:[NSNumber numberWithInt:0]
+ forKey:@"_alternateActionIndex"];
+ NSDictionary* response =
+ [NotificationResponseBuilder buildDictionary:notification];
+
+ NSNumber* operation =
+ [response objectForKey:notification_constants::kNotificationOperation];
+ NSNumber* buttonIndex =
+ [response objectForKey:notification_constants::kNotificationButtonIndex];
+ EXPECT_EQ(0 /* NOTIFICATION_CLICK */, operation.intValue);
+ EXPECT_EQ(0, buttonIndex.intValue);
+}
+
+TEST(NotificationResponseBuilderMacTest, TestNotificationTwoActionClick) {
+ base::scoped_nsobject<NotificationBuilder> builder(
+ [[NotificationBuilder alloc] init]);
+ [builder setTitle:@"Title"];
+ [builder setSubTitle:@"https://www.miguel.com"];
+ [builder setContextMessage:@""];
+ [builder setButtons:@"Button1" secondaryButton:@"Button2"];
+ [builder setTag:@"tag1"];
+ [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
+ [builder setNotificationId:@"notificationId"];
+ [builder setProfileId:@"profileId"];
+ [builder setIncognito:false];
+
+ NSUserNotification* notification = [builder buildUserNotification];
+
+ // These values will be set by the notification center to indicate that button
+ // 2 was clicked.
+ [notification
+ setValue:
+ [NSNumber
+ numberWithInt:NSUserNotificationActivationTypeActionButtonClicked]
+ forKey:@"_activationType"];
+ [notification setValue:[NSNumber numberWithInt:1]
+ forKey:@"_alternateActionIndex"];
+
+ NSDictionary* response =
+ [NotificationResponseBuilder buildDictionary:notification];
+
+ NSNumber* operation =
+ [response objectForKey:notification_constants::kNotificationOperation];
+ NSNumber* buttonIndex =
+ [response objectForKey:notification_constants::kNotificationButtonIndex];
+ EXPECT_EQ(0 /* NOTIFICATION_CLICK */, operation.intValue);
+ EXPECT_EQ(1, buttonIndex.intValue);
+}
+
+TEST(NotificationResponseBuilderMacTest,
+ TestNotificationTwoActionSettingsClick) {
+ base::scoped_nsobject<NotificationBuilder> builder(
+ [[NotificationBuilder alloc] init]);
+ [builder setTitle:@"Title"];
+ [builder setSubTitle:@"https://www.miguel.com"];
+ [builder setContextMessage:@""];
+ [builder setButtons:@"Button1" secondaryButton:@"Button2"];
+ [builder setTag:@"tag1"];
+ [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
+ [builder setNotificationId:@"notificationId"];
+ [builder setProfileId:@"profileId"];
+ [builder setIncognito:false];
+
+ NSUserNotification* notification = [builder buildUserNotification];
+
+ // These values will be set by the notification center to indicate that button
+ // 2 was clicked.
+ [notification
+ setValue:
+ [NSNumber
+ numberWithInt:NSUserNotificationActivationTypeActionButtonClicked]
+ forKey:@"_activationType"];
+ [notification setValue:[NSNumber numberWithInt:2]
+ forKey:@"_alternateActionIndex"];
+
+ NSDictionary* response =
+ [NotificationResponseBuilder buildDictionary:notification];
+
+ NSNumber* operation =
+ [response objectForKey:notification_constants::kNotificationOperation];
+ NSNumber* buttonIndex =
+ [response objectForKey:notification_constants::kNotificationButtonIndex];
+ EXPECT_EQ(2 /* NOTIFICATION_SETTINGS */, operation.intValue);
+ EXPECT_EQ(-1, buttonIndex.intValue);
+}
« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698