Abstract notification clicks in its own dictionary

chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
index 2cd92b4219fd3afd621ab276574471a3ea72f222..9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
@@ -8,6 +8,7 @@
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
+#include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"

[Peter Beverloo, 2016/06/16 17:02:43]

You use #include for this file here, #import elsewhere. In my understanding, the
only difference is that "#import" ensures that a file is only being included
once. Maybe make that consistent?

[Miguel Garcia, 2016/06/17 17:53:08]

Should be include everywhere since it's a c++ file.

 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {
@@ -115,15 +116,15 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {
 
   EXPECT_EQ("https://www.miguel.com",
             base::SysNSStringToUTF8([userInfo
-                objectForKey:notification_builder::kNotificationOrigin]));
+                objectForKey:notification_constants::kNotificationOrigin]));
   EXPECT_EQ("Notification1",
-            base::SysNSStringToUTF8(
-                [userInfo objectForKey:notification_builder::kNotificationId]));
+            base::SysNSStringToUTF8([userInfo
+                objectForKey:notification_constants::kNotificationId]));
   EXPECT_EQ("Profile1",
             base::SysNSStringToUTF8([userInfo
-                objectForKey:notification_builder::kNotificationProfileId]));
+                objectForKey:notification_constants::kNotificationProfileId]));
   EXPECT_TRUE([[userInfo
-      objectForKey:notification_builder::kNotificationIncognito] boolValue]);
+      objectForKey:notification_constants::kNotificationIncognito] boolValue]);
 }
 
 TEST(NotificationBuilderMacTest, TestBuildDictionary) {