Quick View: Format metadata.

Quick View: Format metadata.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/eb6b2f9f77b86d9929b311e869eb6b6c8c1a14ee
Cr-Commit-Position: refs/heads/master@{#400163}

[oka, 2016-06-15 19:04:35]

nit

[oka, 2016-06-15 19:05:12]

rebase

[oka, 2016-06-15 19:06:16]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-15 19:06:17]

PTAL

[fukino, 2016-06-16 04:45:25]

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
(right):

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.html:20:
<!-- TODO(oka): update appearance to match mocks. -->
feature freeze is approaching, so please implement the latest mock design if
possible.

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js
(right):

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:17:
FileMetadataFormatter.prototype.__proto__ = cr.EventTarget.prototype;
Do we need dispatch format change event? (Do we need to handle the case where
the Quick View is opened and metadata is toggled and time format changes?)

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:28:
year: 'numeric',
nit: looks unnecessary style change. (changes from valid style to valid style
might poison blame history.)

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:61: }
else if (
nit: looks unnecessary style change.

[oka, 2016-06-16 05:15:01]

Address comment.

[oka, 2016-06-16 05:18:52]

nit

[oka, 2016-06-16 07:31:05]

PTAL.

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
(right):

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.html:20:
<!-- TODO(oka): update appearance to match mocks. -->
On 2016/06/16 04:45:25, fukino wrote:
> feature freeze is approaching, so please implement the latest mock design if
> possible.

Yes. I'm going to do it in a different CL together with the UI update of quick
view.

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js
(right):

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:17:
FileMetadataFormatter.prototype.__proto__ = cr.EventTarget.prototype;
On 2016/06/16 04:45:25, fukino wrote:
> Do we need dispatch format change event? (Do we need to handle the case where
> the Quick View is opened and metadata is toggled and time format changes?)

Not sure for this case..., I just thought it's better to keep the consistency
between model and view.
Do you recommend to remove listener?

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:28:
year: 'numeric',
On 2016/06/16 04:45:25, fukino wrote:
> nit: looks unnecessary style change. (changes from valid style to valid style
> might poison blame history.) 

Done.

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:61: }
else if (
On 2016/06/16 04:45:25, fukino wrote:
> nit: looks unnecessary style change.

Done.

[fukino, 2016-06-16 14:44:09]

lgtm

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js
(right):

https://codereview.chromium.org/2065933005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js:17:
FileMetadataFormatter.prototype.__proto__ = cr.EventTarget.prototype;
On 2016/06/16 07:31:05, oka wrote:
> On 2016/06/16 04:45:25, fukino wrote:
> > Do we need dispatch format change event? (Do we need to handle the case
where
> > the Quick View is opened and metadata is toggled and time format changes?)
> 
> Not sure for this case..., I just thought it's better to keep the consistency
> between model and view.
> Do you recommend to remove listener?

OK, that makes sense.

[oka, 2016-06-16 15:18:15]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-06-16 15:18:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2065933005/80001

[commit-bot: I haz the power, 2016-06-16 15:56:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-16 15:56:46]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 15:57:29]

Description was changed from

==========
Quick View: Format metadata.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Format metadata.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/eb6b2f9f77b86d9929b311e869eb6b6c8c1a14ee
Cr-Commit-Position: refs/heads/master@{#400163}
==========

[commit-bot: I haz the power, 2016-06-16 15:57:30]

Patchset 5 (id:??) landed as
https://crrev.com/eb6b2f9f77b86d9929b311e869eb6b6c8c1a14ee
Cr-Commit-Position: refs/heads/master@{#400163}