Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2065933002: [gcmole] Fix source files pattern in GYP parsing. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gcmole] Fix source files pattern in GYP parsing. The pattern of how our source files are listed in GYP files changed, which in turn broke the parsing pattern that GCMole uses to gather a list of files to check. Only 'cctest' file were checked, 'src' files were being ignored. R=cbruni@chromium.org Committed: https://crrev.com/fd20e49f4ccd8b07822cdb89e3d278cacb950bcc Cr-Commit-Position: refs/heads/master@{#36962}

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix found issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M src/debug/liveedit.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/gcmole/gcmole.lua View 1 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-14 10:01:33 UTC) #3
Camillo Bruni
LGTM thanks!
4 years, 6 months ago (2016-06-14 10:53:32 UTC) #4
Michael Starzinger
+Michael Achenbach: Just FYI.
4 years, 6 months ago (2016-06-14 10:57:48 UTC) #6
Michael Starzinger
+Yang: PTAL at the fix in live edit for the issue GCMole discovered.
4 years, 6 months ago (2016-06-14 11:15:13 UTC) #8
Yang
On 2016/06/14 11:15:13, Michael Starzinger wrote: > +Yang: PTAL at the fix in live edit ...
4 years, 6 months ago (2016-06-14 11:23:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065933002/40001
4 years, 6 months ago (2016-06-14 12:02:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-14 12:05:16 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 12:08:16 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd20e49f4ccd8b07822cdb89e3d278cacb950bcc
Cr-Commit-Position: refs/heads/master@{#36962}

Powered by Google App Engine
This is Rietveld 408576698