Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 206593005: Remove compositing trigger for CSS transitions (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, jamesr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan, ajuma
Visibility:
Public.

Description

Remove compositing trigger for CSS transitions This feature isn't enabled in any shipping configuration. We might want to add it back after shipping layer squashing. BUG=178119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169704

Patch Set 1 #

Patch Set 2 : remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -143 lines) Patch
D LayoutTests/compositing/transitions/transitions-have-composited-layers.html View 1 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/compositing/transitions/transitions-have-composited-layers-expected.txt View 1 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-20 21:05:14 UTC) #1
Ian Vollick
On 2014/03/20 21:05:14, abarth wrote: lgtm.
6 years, 9 months ago (2014-03-20 21:07:19 UTC) #2
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 9 months ago (2014-03-20 21:07:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206593005/1
6 years, 9 months ago (2014-03-20 21:07:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 21:08:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-20 21:08:48 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 21:43:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206593005/20001
6 years, 9 months ago (2014-03-20 21:43:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 21:44:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-20 21:44:34 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 21:55:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206593005/20001
6 years, 9 months ago (2014-03-20 21:58:04 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 22:49:28 UTC) #13
Message was sent while issue was closed.
Change committed as 169704

Powered by Google App Engine
This is Rietveld 408576698