Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2065913003: Allow prolonged CanvasAsyncBlobCreator lifetime, avoid indirect leaks. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow prolonged CanvasAsyncBlobCreator lifetime, avoid indirect leaks. Weakly keeping this async object to avoid resource leaks is problematic (r399445 + r399675), as the object must remain alive until completed. Undo that experiment and instead keep the object alive until all its posted tasks have been processed. But for the task that wins and is processed first, have it clear out the heap references that would otherwise keep heavy objects alive. R= BUG= Committed: https://crrev.com/ffd698c83520c7efa276decfe453b1a43eb2ab6b Cr-Commit-Position: refs/heads/master@{#399856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. The 'weak' experiment didn't pan out, back to explicit clearing of ...
4 years, 6 months ago (2016-06-15 07:05:37 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-15 07:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065913003/1
4 years, 6 months ago (2016-06-15 07:19:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 08:20:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 08:22:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd698c83520c7efa276decfe453b1a43eb2ab6b
Cr-Commit-Position: refs/heads/master@{#399856}

Powered by Google App Engine
This is Rietveld 408576698