|
|
Created:
4 years, 6 months ago by hta - Chromium Modified:
4 years, 6 months ago CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTurn on MediaConstraints flag by default.
Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA
BUG=543997
Committed: https://crrev.com/b499c91a6b9c413b8b0693791b8c66f13daf9255
Cr-Commit-Position: refs/heads/master@{#399803}
Patch Set 1 #Patch Set 2 : Global interface listing update #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Turn on MediaConstraints flag by default. BUG=543997 ========== to ========== Turn on MediaConstraints flag by default. BUG=543997 ==========
hta@chromium.org changed reviewers: + foolip@chromium.org, jochen@chromium.org
I think it's time...
The CQ bit was checked by hta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065913002/1
lgtm, but please link to the Intent to Ship in the commit message, I've found that useful after the fact.
Description was changed from ========== Turn on MediaConstraints flag by default. BUG=543997 ========== to ========== Turn on MediaConstraints flag by default. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA BUG=543997 ==========
The CQ bit was unchecked by hta@chromium.org
The CQ bit was checked by hta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065913002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by foolip@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065913002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065913002/20001
Message was sent while issue was closed.
Description was changed from ========== Turn on MediaConstraints flag by default. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA BUG=543997 ========== to ========== Turn on MediaConstraints flag by default. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA BUG=543997 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Turn on MediaConstraints flag by default. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA BUG=543997 ========== to ========== Turn on MediaConstraints flag by default. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ANta5sQXoGA BUG=543997 Committed: https://crrev.com/b499c91a6b9c413b8b0693791b8c66f13daf9255 Cr-Commit-Position: refs/heads/master@{#399803} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b499c91a6b9c413b8b0693791b8c66f13daf9255 Cr-Commit-Position: refs/heads/master@{#399803} |