Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2065903002: Fix compilation failure on MIPS64 big-endian. (Closed)

Created:
4 years, 6 months ago by ivica.bogosavljevic
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[stubs] Remove N-argument Hydrogen-based Array constructor stub.' Port: c8ac0d8693f559795eeb3f3aaf386dde166fb2ab Fix compliation failure on MIPS64 big-endian caused by typo in implementation. BUG= Committed: https://crrev.com/bf51705eca0509afe435248eaf8316a15886b0b3 Cr-Commit-Position: refs/heads/master@{#36953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
ivica.bogosavljevic
PTAL
4 years, 6 months ago (2016-06-14 08:27:31 UTC) #2
balazs.kilvady
lgtm. Please fix the message. And add the author to the reviewers. Message should be: ...
4 years, 6 months ago (2016-06-14 08:35:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065903002/1
4 years, 6 months ago (2016-06-14 08:40:06 UTC) #7
ivica.bogosavljevic
4 years, 6 months ago (2016-06-14 08:44:18 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 09:09:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065903002/1
4 years, 6 months ago (2016-06-14 09:10:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 09:13:48 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 09:16:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf51705eca0509afe435248eaf8316a15886b0b3
Cr-Commit-Position: refs/heads/master@{#36953}

Powered by Google App Engine
This is Rietveld 408576698