Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2065893002: bluetooth: android: removed duplicate restart of scanning. (Closed)

Created:
4 years, 6 months ago by perja
Modified:
4 years, 6 months ago
Reviewers:
Ted C, scheib, ortuno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: removed duplicate restart of scanning. This is a followup fix to commit 3a38a46. There is no need to restart the search in this callback as this will be done from native code (BluetoothChooserAndroid::SetAdapterPresence). BUG=543060 Committed: https://crrev.com/e68e28f126ea24755a33d8b72bc1fa1719a8a5b5 Cr-Commit-Position: refs/heads/master@{#401257}

Patch Set 1 #

Patch Set 2 : Moved restart of search from Android chooser to chooser controller. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
perja
This CL fixes an issue from a previous change of mine where the discovery session ...
4 years, 6 months ago (2016-06-14 17:04:57 UTC) #2
ortuno
I would also remove it from BluetoothChooserAndroid::SetAdapterPresence and instead restart the scan from https://cs.chromium.org/chromium/src/content/browser/bluetooth/bluetooth_device_chooser_controller.cc?l=335 if ...
4 years, 6 months ago (2016-06-14 17:22:23 UTC) #3
perja
Makes sense to move this to the device controller. Done that now.
4 years, 6 months ago (2016-06-15 15:03:23 UTC) #4
ortuno
On 2016/06/15 at 15:03:23, perja wrote: > Makes sense to move this to the device ...
4 years, 6 months ago (2016-06-15 15:44:41 UTC) #5
perja
tedchoc: OWNERS review for android files in chrome/.
4 years, 6 months ago (2016-06-15 19:37:46 UTC) #7
Ted C
On 2016/06/15 19:37:46, perja wrote: > tedchoc: OWNERS review for android files in chrome/. chrome ...
4 years, 6 months ago (2016-06-15 19:55:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065893002/20001
4 years, 6 months ago (2016-06-22 11:09:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 12:20:45 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 12:22:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e68e28f126ea24755a33d8b72bc1fa1719a8a5b5
Cr-Commit-Position: refs/heads/master@{#401257}

Powered by Google App Engine
This is Rietveld 408576698